From fd4c42158b577b5a3fb485535c437f8733ee52cd Mon Sep 17 00:00:00 2001 From: Vincent Povirk Date: Thu, 17 Dec 2009 18:13:28 -0600 Subject: [PATCH 3/3] shell32: Fix an access to uninitialized memory in the appbar test. The uninitialized fields are unimportant, but valgrind complains when they are formatted for a trace or sent across a wire. Since we can't prove that there are no important uninitialized fields, zero the structure before it's first used. --- dlls/shell32/tests/appbar.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/shell32/tests/appbar.c b/dlls/shell32/tests/appbar.c index 5e5dfaf..6609f45 100644 --- a/dlls/shell32/tests/appbar.c +++ b/dlls/shell32/tests/appbar.c @@ -210,6 +210,8 @@ static void test_setpos(void) screen_width = GetSystemMetrics(SM_CXSCREEN); screen_height = GetSystemMetrics(SM_CYSCREEN); + memset(&abd, 0, sizeof(abd)); + /* create and register windows[0] */ windows[0].hwnd = CreateWindowExA(WS_EX_TOOLWINDOW|WS_EX_TOPMOST, testwindow_class, testwindow_class, WS_POPUP|WS_VISIBLE, 0, 0, 0, 0, -- 1.6.3.3