>From e60b3e90d862959c1a08b917388e2e33b4df66d4 Mon Sep 17 00:00:00 2001 From: Nikolay Sivov Date: Sun, 8 Jan 2012 03:14:36 +0300 Subject: [PATCH 07/13] Remove redundant loop to count already known value --- dlls/shell32/shv_item_cmenu.c | 25 +++++++++++-------------- 1 files changed, 11 insertions(+), 14 deletions(-) diff --git a/dlls/shell32/shv_item_cmenu.c b/dlls/shell32/shv_item_cmenu.c index 8a97a6e..f1a96cf 100644 --- a/dlls/shell32/shv_item_cmenu.c +++ b/dlls/shell32/shv_item_cmenu.c @@ -73,20 +73,17 @@ static inline ItemCmImpl *impl_from_IContextMenu2(IContextMenu2 *iface) * ISvItemCm_CanRenameItems() */ static BOOL ISvItemCm_CanRenameItems(ItemCmImpl *This) -{ UINT i; - DWORD dwAttributes; +{ + DWORD attr; - TRACE("(%p)->()\n",This); + TRACE("(%p)\n", This); - if(This->apidl) - { - for(i = 0; i < This->cidl; i++){} - if(i > 1) return FALSE; /* can't rename more than one item at a time*/ - dwAttributes = SFGAO_CANRENAME; - IShellFolder_GetAttributesOf(This->menu.parent, 1, (LPCITEMIDLIST*)This->apidl, &dwAttributes); - return dwAttributes & SFGAO_CANRENAME; - } - return FALSE; + /* can't rename more than one item at a time*/ + if (!This->apidl || This->cidl > 1) return FALSE; + + attr = SFGAO_CANRENAME; + IShellFolder_GetAttributesOf(This->menu.parent, 1, (LPCITEMIDLIST*)This->apidl, &attr); + return attr & SFGAO_CANRENAME; } /************************************************************************** -- 1.5.6.5