<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>I think the patch must be accepted because original codes are more wrong.</div><div><br></div><div>Tests will be created when <span style="font-size: 13px; white-space: pre-wrap;">WINED3D_CKEY_COLORSPACE will be implemented.</span></div><div><span style="font-size: 13px; white-space: pre-wrap;"><br></span></div><div><span style="font-size: 13px; white-space: pre-wrap;">The game affected is in bug 38581.</span></div><div><span style="font-size: 13px; white-space: pre-wrap;"><br></span></div><div><span style="font-size: 13px; white-space: pre-wrap;">Meanwhile, the policy to reject any patches is not constructive.</span></div><div><span style="font-size: 13px; white-space: pre-wrap;">If one developer propose not perfect codes then next developer can correct them and obtain a result.</span></div><div><span style="font-size: 13px; white-space: pre-wrap;">If you rejected the first developer then you will not have a result.</span></div><div><span style="font-size: 13px; white-space: pre-wrap;"><br></span></div><div><span style="font-size: 13px; white-space: pre-wrap;">Best wishes!</span></div><div><br></div><br><div><div>On 27 мая 2015 г., at 10:39, Stefan Dösinger <<a href="mailto:stefandoesinger@gmail.com">stefandoesinger@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">-----BEGIN PGP SIGNED MESSAGE-----<br>Hash: SHA1<br><br>Am 2015-05-26 um 14:41 schrieb Sergey Isakov:<br><blockquote type="cite">+#define RED_KEY(x) (x & 0xff0000)<br>+#define GREEN_KEY(x) (x & 0x00ff00) <br>+#define BLUE_KEY(x) (x & 0x0000ff)<br>+ return ((RED_KEY(color) >= RED_KEY(color_key->color_space_low_value)) &&<br>+ (RED_KEY(color) <= RED_KEY(color_key->color_space_high_value)) &&<br>+ (GREEN_KEY(color) >= GREEN_KEY(color_key->color_space_low_value)) &&<br>+ (GREEN_KEY(color) <= GREEN_KEY(color_key->color_space_high_value)) &&<br>+ (BLUE_KEY(color) >= BLUE_KEY(color_key->color_space_low_value)) &&<br>+ (BLUE_KEY(color) <= BLUE_KEY(color_key->color_space_high_value)));<br>+#undef RED_KEY<br>+#undef GREEN_KEY<br>+#undef BLUE_KEY<br></blockquote>The basic idea is most likely right, but it needs tests. Do you have a game that needs this behavior?<br><br>The way you're extracting individual colors from the key is wrong. The bitmasks depend on the texture format.<br><br>The code you're modifying is unused on any modern GPU. On GPUs that support ARB_fragment_program or GLSL we do the color key comparison in the fragment shader nowadays.<br><br>-----BEGIN PGP SIGNATURE-----<br>Version: GnuPG v2<br><br>iQIcBAEBAgAGBQJVZXSWAAoJEN0/YqbEcdMwbEUP/RM4QUsbdSzhSLyIz5j00Epb<br>AW1ZcNOg61yrfymjHdhJkqfdNmEiKQFsRshD+ZQAxVHqMsZLTxXtRFfBB14WtmNI<br>Ng5jwwiAzDqlmpjftlZ4CmkR1w7DMxH6Nt4e9OQBlDKShSIoGngL6RremV+2Wq+f<br>nNC6HfdmUiAIReVvI2aMm5B9C5L624SKLvoAZNI8QW+HJeZeESSGmT9bx4IRVQwl<br>QX+aKojT43CJwq6UpZRu7ZkniotrmO9aDC+6S3S0od0ZJWSP5Q9upCNWNcN+iPG7<br>9kCPwZMsEAxNUjvh/wQx8xE1+wiR7Ugjl/X6yTN8HFesFHChrqC2UeHUAkUKU++L<br>WC4kwijfbktKSZnIiSvrTAzWvLOeCZMifFQqm8aqmlOqyvbNwyOJjh6yM/nqZi+c<br>2aEdEIMY5aaoswDIlyGRRN57zeWtqjZVmg7UzVxmZqfiocmUVxgdmdRv8BvFi0RF<br>R4A6YTDP5EYb33SvH3qQE5kIrtDdtL8qtanmBsuHnhhwd1rdgeeq/9N0tqSjH1GQ<br>s8vsXVmd3qU+mQMzyaxN9Cc9RGxGNgd+g1LkkoPqe+aVUw/JDzvAdMDGpy63zjhM<br>QUlfS771f+Zt43wku/20XP1engXXti4m+KfnSOS3nCdKO1xRKOGHAMlUZzd8+jhU<br>2rWKuh42D3mSMDk1OhLR<br>=IdO/<br>-----END PGP SIGNATURE-----<br></blockquote></div><br></body></html>