msxml3: Fix printing NULL strings

Francois Gouget fgouget at free.fr
Sun Sep 18 15:26:54 CDT 2011


On Sun, 18 Sep 2011, Dan Kegel wrote:
[...]
> $ ccache gcc -c -I. -I. -I../../include -I../../include
> -I/usr/include/libxml2   -I/usr/include/libxml2   -D__WINESRC__
> -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing
> -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes
> -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op  -g -O0
> -Werror  -o element.o element.c
> 
> cc1: warnings being treated as errors
> element.c: In function ‘variant_from_dt’:
> element.c:666: error: pointer targets in passing argument 1 of
> ‘debugstr_a’ differ in signedness
> ../../include/wine/debug.h:259: note: expected ‘const char *’ but
> argument is of type ‘const xmlChar *’

I'm not sure how to fix that.
 1) I could add (char*) casts everywhere but that's quite ugly.
 2) I could create a macro. Probably uglier.
 3) Or I could create a debugstr_ua() that takes unsigned chars.
    (And calls debugstr_a() with a cast)

I'm kind of leaning towards the third option.

-- 
Francois Gouget <fgouget at free.fr>              http://fgouget.free.fr/
              E-Voting: Those who cast the votes decide nothing.
                 Those who count the votes decide everything.


More information about the wine-tests-results mailing list