[Wine] Re: No hide button in 0.9.60 ?

[vitamin]

James McKenzie wrote:
> Austin English wrote:
> 
> > On Sun, Apr 27, 2008 at 6:38 PM, vitamin <wineforum-user at winehq.org> wrote:
> > 
> > 
> > > austin987 wrote:
> > > 
> > > > On Sun, Apr 27, 2008 at 5:06 AM, Spuuk <wineforum-user at winehq.org> wrote:
> > > > 
> > > > 
> > > > > this one ?
> > > > > 
> > > > > spuuk at GST:~/wine-git$ git bisect good
> > > > > fc29e334f6dcaf566bc17c5c5514929a395686f8 is first bad commit
> > > > > commit fc29e334f6dcaf566bc17c5c5514929a395686f8
> > > > > Author: Vincent Povirk <madewokherd+d41d at gmail.com>
> > > > > Date:   Sat Apr 12 20:30:42 2008 -0400
> > > > > 
> > > > > 
> > > > > start.exe: Add /Unix switch for native file managers.
> > > > > 
> > > > > :040000 040000 5733b96c3e0b65c9a02620c8b070c36cadf82698 016c4b86a6518cd781a0b1ceffa5e0ea12cc851b M programs
> > > > > 
> > > > > 
> > > > > 
> > > > > 
> > > > > 
> > > > > 
> > > > > 
> > > > > 
> > > > 
> > > > Doesn't sound like it should be the cause. Try:
> > > > $ git revert fc29e334f6dcaf566bc17c5c5514929a395686f8
> > > > 
> > > > recompile and see if it works then.
> > > > 
> > > 
> > > 
> > > PLEASE DON'T!!!
> > > The best way to do this is
> > > 
> > > Code:
> > > git show fc29e334f6dcaf566bc17c5c5514929a395686f8 | patch -p1 -R
> > > 
> > > 
> > What's wrong with git revert?
> > 
> > 
> > 
> Vitamin and Austin:
> 
> It appears that you both are attempting to do the same thing.  
> git-revert with the commit number should reverse the patch as does the 
> git-show | patch -p1 -R command.   So, like Austin asked, is there 
> something wrong with git-revert?  If so, this should be reported to the 
> git team so they can fix it.
> 
> James McKenzie


They do both alter source code you are correct. However, that's the only thing my method does. What Austin suggests alters index.

What "git revert" does is it creates and commits a reverse patch on top of HEAD. This something for developers to deal with. And they know where to look and what to do.

For users it will create extra set of problems. As they can't do 'git pull' anymore - their "master" is no longer the same as "origin". And they explicitly have to remove that commit with "git reset --hard". And if you forget to do this and continue on the standard path 'git fetch; git rebase origin' you will end up with problems down the round. You still have that revert patch in your tree!