wine-commits January 2022

2 participants
726 discussions

Rémi Bernon : user32/tests: Add some possible broken results on Win7.

by Alexandre Julliard

Module: wine Branch: master Commit: 9fea10cceb0fbc0cf3111f462c98f7b994d5c893 URL: https://source.winehq.org/git/wine.git/?a=commit;h=9fea10cceb0fbc0cf3111f46… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Mon Jan 31 14:18:09 2022 +0100 user32/tests: Add some possible broken results on Win7. Can be reproduced randomly even without user32:monitor, for instance running user32:win in a fresh Win7 VM. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=51392 Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/tests/win.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c index 24d0cb0ae2e..ba9b16d89bd 100644 --- a/dlls/user32/tests/win.c +++ b/dlls/user32/tests/win.c @@ -7127,7 +7127,7 @@ static void test_ShowWindow(void) { HWND hwnd; DWORD style; - RECT rcMain, rc, rcMinimized, rcClient, rcEmpty, rcMaximized, rcResized, rcNonClient; + RECT rcMain, rc, rcMinimized, rcClient, rcEmpty, rcMaximized, rcResized, rcNonClient, rcBroken; LPARAM ret; MONITORINFO mon_info; unsigned int i; @@ -7430,8 +7430,17 @@ static void test_ShowWindow(void) style = GetWindowLongA(hwnd, GWL_STYLE); ok(style & WS_MAXIMIZE, "Test %u: window should be maximized\n", i); GetWindowRect(hwnd, &rc); - ok(EqualRect(&rcMaximized, &rc), "Test %u: expected %s, got %s\n", - i, wine_dbgstr_rect(&rcMaximized), wine_dbgstr_rect(&rc)); + + rcBroken = rcMaximized; + if (test_style[i] & WS_THICKFRAME) + { + InflateRect(&rcBroken, -2, -2); + OffsetRect(&rcBroken, -2, -2); + } + + ok(EqualRect(&rcMaximized, &rc) || broken(EqualRect(&rcBroken, &rc)), + "Test %u: expected %s, got %s\n", i, wine_dbgstr_rect(&rcMaximized), + wine_dbgstr_rect(&rc)); ret = ShowWindow(hwnd, SW_RESTORE); ok(ret, "unexpected ret: %lu\n", ret);

2 years, 2 months

Rémi Bernon : user32/tests: Add proper tests for SetActiveWindow(0).

by Alexandre Julliard

Module: wine Branch: master Commit: ebe3cea01d127de612171b6276c473a2b455266d URL: https://source.winehq.org/git/wine.git/?a=commit;h=ebe3cea01d127de612171b62… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Mon Jan 31 14:18:08 2022 +0100 user32/tests: Add proper tests for SetActiveWindow(0). Shows that it switches focus to some other process window and back, and only on some older Windows versions. Win10 simply returns 0 and does nothing. Stop calling it elsewhere, as it makes focus go to an unpredictable window, which may very well not be ours. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=51391 Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=51130 Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/tests/win.c | 209 ++++++++++++++++++++++++++++++++++++------------ 1 file changed, 156 insertions(+), 53 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=ebe3cea01d127de61217…

2 years, 2 months

Rémi Bernon : user32/tests: Ignore messages for UserAdapterWindowClass windows.

by Alexandre Julliard

Module: wine Branch: master Commit: fa28e05cf5b0101fb046c4845391634791268200 URL: https://source.winehq.org/git/wine.git/?a=commit;h=fa28e05cf5b0101fb046c484… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Mon Jan 31 14:18:07 2022 +0100 user32/tests: Ignore messages for UserAdapterWindowClass windows. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=48815 Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/tests/win.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c index 4c0bd430180..ae2f5d66a10 100644 --- a/dlls/user32/tests/win.c +++ b/dlls/user32/tests/win.c @@ -170,8 +170,14 @@ static void check_active_state_(const char *file, int line, ok_(file, line)(focus == GetFocus(), "GetFocus() = %p\n", GetFocus()); } -static BOOL ignore_message( UINT message ) +static BOOL ignore_message( UINT message, HWND hwnd ) { + WCHAR buffer[256]; + + if (GetClassNameW( hwnd, buffer, ARRAY_SIZE(buffer) ) == 22 && + !wcscmp( buffer, L"UserAdapterWindowClass" )) + return TRUE; + /* these are always ignored */ return (message >= 0xc000 || message == WM_GETICON || @@ -179,8 +185,7 @@ static BOOL ignore_message( UINT message ) message == WM_TIMER || message == WM_SYSTIMER || message == WM_TIMECHANGE || - message == WM_DEVICECHANGE || - message == 0x0060 /* undocumented, used by Win10 1709+ */); + message == WM_DEVICECHANGE); } static BOOL CALLBACK EnumChildProc( HWND hwndChild, LPARAM lParam) @@ -3953,7 +3958,7 @@ static BOOL peek_message( MSG *msg ) do { ret = PeekMessageA(msg, 0, 0, 0, PM_REMOVE); - } while (ret && ignore_message(msg->message)); + } while (ret && ignore_message(msg->message, msg->hwnd)); return ret; } @@ -4113,7 +4118,7 @@ static void test_mouse_input(HWND hwnd) /* FIXME: SetCursorPos in Wine generates additional WM_MOUSEMOVE message */ while (PeekMessageA(&msg, 0, 0, 0, PM_REMOVE)) { - if (ignore_message(msg.message)) continue; + if (ignore_message(msg.message, msg.hwnd)) continue; ok(msg.hwnd == popup && msg.message == WM_MOUSEMOVE, "hwnd %p message %04x\n", msg.hwnd, msg.message); DispatchMessageA(&msg);

2 years, 2 months

Rémi Bernon : user32/tests: Tweak window size to fix Win10 results.

by Alexandre Julliard

Module: wine Branch: master Commit: 34d1c100b044afa5eb6d6243e9fb40db085b78d2 URL: https://source.winehq.org/git/wine.git/?a=commit;h=34d1c100b044afa5eb6d6243… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Mon Jan 31 14:18:06 2022 +0100 user32/tests: Tweak window size to fix Win10 results. Fix these failures: > win.c:2445: Test failed: style 0x200000: expected !100 > win.c:2445: Test failed: style 0x300000: expected !100 Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/tests/win.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c index 273dc8bd8ed..4c0bd430180 100644 --- a/dlls/user32/tests/win.c +++ b/dlls/user32/tests/win.c @@ -2249,7 +2249,7 @@ static void test_mdi(void) mdi_hwndMain = CreateWindowExA(0, "MDI_parent_Class", "MDI parent window", WS_CAPTION | WS_SYSMENU | WS_MINIMIZEBOX | WS_MAXIMIZEBOX /*| WS_VISIBLE*/, - 100, 100, CW_USEDEFAULT, CW_USEDEFAULT, + 200, 100, CW_USEDEFAULT, CW_USEDEFAULT, GetDesktopWindow(), 0, GetModuleHandleA(NULL), NULL); assert(mdi_hwndMain);

2 years, 2 months

Eric Pouech : ntdll: Use correct integral type.

by Alexandre Julliard

Module: wine Branch: master Commit: 310d7c688346e89a1cb0f4ec7cfbb0e690015543 URL: https://source.winehq.org/git/wine.git/?a=commit;h=310d7c688346e89a1cb0f4ec… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Mon Jan 31 14:17:06 2022 +0100 ntdll: Use correct integral type. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/actctx.c | 2 +- dlls/ntdll/loader.c | 16 ++++++++-------- dlls/ntdll/sync.c | 12 ++++++------ 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/dlls/ntdll/actctx.c b/dlls/ntdll/actctx.c index ca38f37e673..9fa93a3b5e3 100644 --- a/dlls/ntdll/actctx.c +++ b/dlls/ntdll/actctx.c @@ -532,7 +532,7 @@ enum context_sections typedef struct _ACTIVATION_CONTEXT { ULONG magic; - int ref_count; + LONG ref_count; struct file_info config; struct file_info appdir; struct assembly *assemblies; diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c index b50b9e61bbc..2c3e62f6e25 100644 --- a/dlls/ntdll/loader.c +++ b/dlls/ntdll/loader.c @@ -90,8 +90,8 @@ static BOOL is_prefix_bootstrap; /* are we bootstrapping the prefix? */ static BOOL imports_fixup_done = FALSE; /* set once the imports have been fixed up, before attaching them */ static BOOL process_detaching = FALSE; /* set on process detach to avoid deadlocks with thread detach */ static int free_lib_count; /* recursion depth of LdrUnloadDll calls */ -static ULONG path_safe_mode; /* path mode set by RtlSetSearchPathMode */ -static ULONG dll_safe_mode = 1; /* dll search mode */ +static LONG path_safe_mode; /* path mode set by RtlSetSearchPathMode */ +static LONG dll_safe_mode = 1; /* dll search mode */ static UNICODE_STRING dll_directory; /* extra path for LdrSetDllDirectory */ static UNICODE_STRING system_dll_path; /* path to search for system dependency dlls */ static DWORD default_search_flags; /* default flags set by LdrSetDefaultDllDirectories */ @@ -250,8 +250,8 @@ RTL_UNLOAD_EVENT_TRACE * WINAPI RtlGetUnloadEventTrace(void) */ void WINAPI RtlGetUnloadEventTraceEx(ULONG **size, ULONG **count, void **trace) { - static unsigned int element_size = sizeof(*unload_traces); - static unsigned int element_count = ARRAY_SIZE(unload_traces); + static ULONG element_size = sizeof(*unload_traces); + static ULONG element_count = ARRAY_SIZE(unload_traces); *size = &element_size; *count = &element_count; @@ -3334,7 +3334,7 @@ NTSTATUS WINAPI LdrQueryProcessModuleInformation(RTL_PROCESS_MODULES *smi, } -static NTSTATUS query_dword_option( HANDLE hkey, LPCWSTR name, ULONG *value ) +static NTSTATUS query_dword_option( HANDLE hkey, LPCWSTR name, LONG *value ) { NTSTATUS status; UNICODE_STRING str; @@ -4369,7 +4369,7 @@ NTSTATUS WINAPI RtlSetSearchPathMode( ULONG flags ) val = 0; break; case BASE_SEARCH_PATH_ENABLE_SAFE_SEARCHMODE | BASE_SEARCH_PATH_PERMANENT: - InterlockedExchange( (int *)&path_safe_mode, 2 ); + InterlockedExchange( &path_safe_mode, 2 ); return STATUS_SUCCESS; default: return STATUS_INVALID_PARAMETER; @@ -4377,9 +4377,9 @@ NTSTATUS WINAPI RtlSetSearchPathMode( ULONG flags ) for (;;) { - int prev = path_safe_mode; + LONG prev = path_safe_mode; if (prev == 2) break; /* permanently set */ - if (InterlockedCompareExchange( (int *)&path_safe_mode, val, prev ) == prev) return STATUS_SUCCESS; + if (InterlockedCompareExchange( &path_safe_mode, val, prev ) == prev) return STATUS_SUCCESS; } return STATUS_ACCESS_DENIED; } diff --git a/dlls/ntdll/sync.c b/dlls/ntdll/sync.c index bdb39e59d6d..06b594c633f 100644 --- a/dlls/ntdll/sync.c +++ b/dlls/ntdll/sync.c @@ -182,12 +182,12 @@ static inline NTSTATUS wait_semaphore( RTL_CRITICAL_SECTION *crit, int timeout ) } else { - int *lock = (int *)&crit->LockSemaphore; + LONG *lock = (LONG *)&crit->LockSemaphore; while (!InterlockedCompareExchange( lock, 0, 1 )) { - static const int zero; + static const LONG zero; /* this may wait longer than specified in case of multiple wake-ups */ - if (RtlWaitOnAddress( lock, &zero, sizeof(int), &time ) == STATUS_TIMEOUT) + if (RtlWaitOnAddress( lock, &zero, sizeof(LONG), &time ) == STATUS_TIMEOUT) return STATUS_TIMEOUT; } return STATUS_WAIT_0; @@ -363,7 +363,7 @@ NTSTATUS WINAPI RtlpUnWaitCriticalSection( RTL_CRITICAL_SECTION *crit ) } else { - int *lock = (int *)&crit->LockSemaphore; + LONG *lock = (LONG *)&crit->LockSemaphore; InterlockedExchange( lock, 1 ); RtlWakeAddressSingle( lock ); ret = STATUS_SUCCESS; @@ -761,7 +761,7 @@ void WINAPI RtlInitializeConditionVariable( RTL_CONDITION_VARIABLE *variable ) */ void WINAPI RtlWakeConditionVariable( RTL_CONDITION_VARIABLE *variable ) { - InterlockedIncrement( (int *)&variable->Ptr ); + InterlockedIncrement( (LONG *)&variable->Ptr ); RtlWakeAddressSingle( variable ); } @@ -772,7 +772,7 @@ void WINAPI RtlWakeConditionVariable( RTL_CONDITION_VARIABLE *variable ) */ void WINAPI RtlWakeAllConditionVariable( RTL_CONDITION_VARIABLE *variable ) { - InterlockedIncrement( (int *)&variable->Ptr ); + InterlockedIncrement( (LONG *)&variable->Ptr ); RtlWakeAddressAll( variable ); }

2 years, 2 months

Eric Pouech : joy.cpl: Use correct integral type.

by Alexandre Julliard

Module: wine Branch: master Commit: 1c374a7c51eade2b0d6f03b363873b0acf73ff6c URL: https://source.winehq.org/git/wine.git/?a=commit;h=1c374a7c51eade2b0d6f03b3… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Mon Jan 31 14:16:38 2022 +0100 joy.cpl: Use correct integral type. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/joy.cpl/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/joy.cpl/main.c b/dlls/joy.cpl/main.c index 081dcf2dc74..8ea3892b750 100644 --- a/dlls/joy.cpl/main.c +++ b/dlls/joy.cpl/main.c @@ -789,7 +789,7 @@ static BOOL CALLBACK ff_effects_callback(const DIEFFECTINFOW *pdei, void *pvRef) HRESULT hr; DIEFFECT dieffect; DWORD axes[2] = {DIJOFS_X, DIJOFS_Y}; - int direction[2] = {0, 0}; + LONG direction[2] = {0, 0}; int num_axes = 2; struct Joystick *joystick = pvRef; DIRAMPFORCE rforce;

2 years, 2 months

Eric Pouech : itss: Use correct integral type.

by Alexandre Julliard

Module: wine Branch: master Commit: 7e90d60233966b151b977938f75408b4ea472665 URL: https://source.winehq.org/git/wine.git/?a=commit;h=7e90d60233966b151b977938… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Mon Jan 31 14:16:24 2022 +0100 itss: Use correct integral type. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/itss/chm_lib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/itss/chm_lib.c b/dlls/itss/chm_lib.c index 91e3fa3d811..f2665cae529 100644 --- a/dlls/itss/chm_lib.c +++ b/dlls/itss/chm_lib.c @@ -941,7 +941,7 @@ static UChar *_chm_find_in_PMGL(UChar *page_buf, * that is provided for us. */ struct chmPmglHeader header; - UInt32 hremain; + unsigned int hremain; UChar *end; UChar *cur; UChar *temp; @@ -983,7 +983,7 @@ static Int32 _chm_find_in_PMGI(UChar *page_buf, * that is provided for us */ struct chmPmgiHeader header; - UInt32 hremain; + unsigned int hremain; int page=-1; UChar *end; UChar *cur; @@ -1093,7 +1093,7 @@ static BOOL _chm_get_cmpblock_bounds(struct chmFile *h, Int64 *len) { UChar buffer[8], *dummy; - UInt32 remain; + unsigned int remain; /* for all but the last block, use the reset table */ if (block < h->reset_table.block_count-1)

2 years, 2 months

Eric Pouech : dsound: Use correct integral type.

by Alexandre Julliard

Module: wine Branch: master Commit: c5b0974b93b7cc54aee4defdda445b0aa7e89a35 URL: https://source.winehq.org/git/wine.git/?a=commit;h=c5b0974b93b7cc54aee4defd… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Mon Jan 31 14:15:17 2022 +0100 dsound: Use correct integral type. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dsound/mixer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/dsound/mixer.c b/dlls/dsound/mixer.c index d28cc8dc5aa..1f91bc4dc0e 100644 --- a/dlls/dsound/mixer.c +++ b/dlls/dsound/mixer.c @@ -694,7 +694,8 @@ static void DSOUND_WaveQueue(DirectSoundDevice *device, LPBYTE pos, DWORD bytes) */ static void DSOUND_PerformMix(DirectSoundDevice *device) { - DWORD block, pad_frames, pad_bytes, frames; + DWORD block, pad_bytes, frames; + UINT32 pad_frames; HRESULT hr; TRACE("(%p)\n", device);

2 years, 2 months

Eric Pouech : dbgeng: Use correct integral type.

by Alexandre Julliard

Module: wine Branch: master Commit: a41b45a8c5a7ca178748c09aaaca519aaa028d7e URL: https://source.winehq.org/git/wine.git/?a=commit;h=a41b45a8c5a7ca178748c09a… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Mon Jan 31 14:14:18 2022 +0100 dbgeng: Use correct integral type. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dbgeng/dbgeng.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dlls/dbgeng/dbgeng.c b/dlls/dbgeng/dbgeng.c index 014f723981b..5ffde0e3c80 100644 --- a/dlls/dbgeng/dbgeng.c +++ b/dlls/dbgeng/dbgeng.c @@ -81,7 +81,7 @@ static struct target_process *debug_client_get_target(struct debug_client *debug } static HRESULT debug_target_return_string(const char *str, char *buffer, unsigned int buffer_size, - unsigned int *size) + ULONG *size) { unsigned int len = strlen(str), dst_len; @@ -1877,7 +1877,8 @@ static HRESULT STDMETHODCALLTYPE debugsymbols_GetModuleVersionInformation(IDebug struct target_process *target; void *version_info, *ptr; HRESULT hr = E_FAIL; - DWORD handle, size; + DWORD handle; + UINT size; TRACE("%p, %u, %s, %s, %p, %u, %p.\n", iface, index, wine_dbgstr_longlong(base), debugstr_a(item), buffer, buffer_size, info_size);

2 years, 2 months

Eric Pouech : winedbg: Use correct integral type.

by Alexandre Julliard

Module: wine Branch: master Commit: f44f3c23a6fd029d208947f90aba5193bb1f2b82 URL: https://source.winehq.org/git/wine.git/?a=commit;h=f44f3c23a6fd029d208947f9… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Mon Jan 31 14:14:11 2022 +0100 winedbg: Use correct integral type. (* as width or precision specifier in printf requires an int not a long) Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/winedbg/debugger.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/programs/winedbg/debugger.h b/programs/winedbg/debugger.h index b676bc8d955..0cc2f8b7a6c 100644 --- a/programs/winedbg/debugger.h +++ b/programs/winedbg/debugger.h @@ -39,7 +39,7 @@ #include "oaidl.h" #include <wine/list.h> -#define ADDRSIZE (dbg_curr_process ? dbg_curr_process->be_cpu->pointer_size : (int)sizeof(void*)) +#define ADDRSIZE ((int)(dbg_curr_process ? dbg_curr_process->be_cpu->pointer_size : sizeof(void*))) #define ADDRWIDTH (ADDRSIZE * 2) /* the debugger uses these exceptions for its internal use */

2 years, 2 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits January 2022