wine-devel February 2013

62 participants
126 discussions

Re: [PATCH 2/4] vbscript: Added color constants.
by Marvin 27 Feb '13

27 Feb '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24538 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/3] wininet: Remember that headers were not received.
by Jacek Caban 27 Feb '13

27 Feb '13

Hi Ričardas, On 02/27/13 00:07, Ričardas Barkauskas wrote: > @@ -5708,6 +5708,7 @@ static INT HTTP_GetResponseHeaders(http_request_t *request, BOOL clear) > > heap_free(request->rawHeaders); > request->rawHeaders = heap_strdupW(szDefaultHeader); > + request->flags |= INTERNET_REQFLAG_NO_HEADERS; I don't think we want to maintain valid request->flags for that particular flag. Checking for request->rawHeaders should be enough. If we avoided setting rawHeaders here, we'd achieve the same behaviour. Jacek

1 0

Re: msvcrt/tests: Mark win8 behaviour as broken
by Piotr Caban 27 Feb '13

27 Feb '13

On 02/26/13 23:57, André Hentschel wrote: > diff --git a/dlls/msvcrt/tests/time.c b/dlls/msvcrt/tests/time.c > index 30d9fa7..3d00769 100644 > --- a/dlls/msvcrt/tests/time.c > +++ b/dlls/msvcrt/tests/time.c > @@ -181,8 +181,8 @@ static void test_gmtime(void) > err = p_gmtime32_s(&gmt_tm_s, &gmt); > - ok(gmt_tm_s.tm_year==-1 || broken(gmt_tm_s.tm_year==70 && gmt_tm->tm_sec<0), > - "tm_year = %d\n", gmt_tm_s.tm_year); > + ok(gmt_tm_s.tm_year==-1 || broken(gmt_tm_s.tm_year==70), > + "tm_year = %d, tm_sec = %d\n", gmt_tm_s.tm_year, gmt_tm->tm_sec); This test was checking wrong structure. It should use gmt_tm_s struct for testing seconds instead of gmt_tm.

1 0

Re: [1/3] wininet: Remember that headers were not received.
by Marvin 26 Feb '13

26 Feb '13

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=24535 Your paranoid android. === W7PROX64 (32 bit http) === http.c:3337: Test failed: HttpSendRequest failed: 12002

1 0

Re: gdi32: Fix the GdiGetCodePage() support ANSI_CHARSET font associated charset
by Akihiro Sagawa 26 Feb '13

26 Feb '13

On Sun, 24 Feb 2013 09:55:59 +0900, Byeongsik Jeon wrote: Could you consider adding "(try N)" at the end of subject line? The rule is documented here: http://wiki.winehq.org/SubmittingPatches#head-fea51bfdf6a29105a9a6fc6f5886a… > diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c > index b274b83..3a99d35 100644 > --- a/dlls/gdi32/font.c > +++ b/dlls/gdi32/font.c > @@ -590,11 +590,75 @@ HFONT WINAPI CreateFontW( INT height, INT width, INT esc, This part looks good. > diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c (snip) > +static void update_font_association_info(UINT current_ansi_codepage) > +{ > + static const WCHAR font_assoc_reg_keyW[] = {'S','y','s','t','e','m','\\', > + 'C','u','r','r','e','n','t','C','o','n','t','r','o','l','S','e','t','\\', > + 'C','o','n','t','r','o','l','\\','F','o','n','t','A','s','s','o','c','\0'}; It is nice introducing separate function for this work. However using WCHAR is a bit overwork, because ANSI APIs are still used in update_font_info() especially set_value_key(). Please follow the style of surrounding code. > @@ -3615,6 +3675,10 @@ static void update_font_info(void) > } > if (!done) > FIXME("there is no font defaults for codepages %u,%u\n", ansi_cp, oem_cp); > + > + /* update locale dependent font association info in registry */ > + if (strcmp(buf, cpbuf)) > + update_font_association_info(ansi_cp); > } > > static BOOL init_freetype(void) This condition should be rewritten. buf is not initialized when RegQueryValueExA is failed in line 3542. And strcmp(buf, cpbuf) has already done in line 3544. > diff --git a/dlls/gdi32/tests/font.c b/dlls/gdi32/tests/font.c > index 943f584..9d57806 100644 > --- a/dlls/gdi32/tests/font.c > +++ b/dlls/gdi32/tests/font.c Why are there no tests against OEM_CHARSET and SYMBOL_CHARSET? Regards, Akihiro Sagawa

2 2

Re: riched20: Remove redundant 'return;' statements.
by Dmitry Timoshkov 26 Feb '13

26 Feb '13

This patch is marked as 'Rejected', and I can't find an e-mail to wine-devel with an explanation why. -- Dmitry.

2 1

Re: comctl32/listview: fix mouse message sequences
by Nikolay Sivov 26 Feb '13

26 Feb '13

On 2/24/2013 01:33, Daniel Jelinski wrote: > @@ -10178,6 +10139,19 @@ static LRESULT LISTVIEW_LButtonDown(LISTVIEW_INFO *infoPtr, WORD wKey, INT x, IN > > if (infoPtr->dwLvExStyle & LVS_EX_ONECLICKACTIVATE) > if(lvHitTestInfo.iItem != -1) notify_itemactivate(infoPtr,&lvHitTestInfo); > + if (LISTVIEW_TrackMouse(infoPtr, pt)) > + { > + NMLISTVIEW nmlv; > + > + ZeroMemory(&nmlv, sizeof(nmlv)); > + nmlv.iItem = lvHitTestInfo.iItem; > + nmlv.ptAction = infoPtr->ptClickPos; > + > + notify_listview(infoPtr, LVN_BEGINDRAG, &nmlv); > + infoPtr->bDragging = TRUE; > + } > + else > + LISTVIEW_LButtonUp(infoPtr,0,x,y); This doesn't look very clean. I mean invoking *up handler from a *down one. Is this something that could be resolved with message loop like rbutton dragging was fixed?

2 3

Re: winetest: Add a link to the test summary page that specifies the test configuration details, the dll versions, etc.
by Alexandre Julliard 25 Feb '13

25 Feb '13

Francois Gouget <fgouget(a)codeweavers.com> writes: > Clarify two other link names to avoid confusion. > --- > > I did not test this patch so it should be verified carefully before > committing. I recently found myself annoyed that I could not go from a > page such as this one: > > http://test.winehq.org/data/209b58c64e6181c9bf448cb4f3130d3ba705c5d2/win7_n… > > to what I call that test's summary page: > > http://test.winehq.org/data/209b58c64e6181c9bf448cb4f3130d3ba705c5d2/win7_n… > > Of course 'summary' referred instead to the page with all the 'build > results' which I found very confusing. So I renamed it to just that > ('build results', not 'confusing' <g>). Then I renamed the 'index' link > to 'home' since it points to the winetest site's landing page (aka its > 'home' page). I'm not sure that's better. Particularly since that summary page is helpfully called "Main summary", it's not that confusing. The version info is obtained on other pages by clicking on the test tag, so we could potentially display the test tag on the individual test page too. -- Alexandre Julliard julliard(a)winehq.org

1 0

A new demangler test?
by Max TenEyck Woodbury 25 Feb '13

25 Feb '13

Would it be appropriate to add a test to the name demangler that: 1) Scans all '.dll' and '.spac' files for mangled names, and 2) Tries to decode those names. 3) Prints the mangled and decoded names and where they occur. Success would be that all names decode without the decoder blowing up or failing.

4 6

Re: [2/3] gdiplus: Round up when converting from 32-bit ARGB to PARGB.
by Vincent Povirk 25 Feb '13

25 Feb '13

Are you sure about this? Other tests have suggested that native is not this exact when dealing with color values, and different OS versions have produced slightly different results. Is there an application that relies on this, or is there a reason this is generally more correct behavior when premultiplying alpha?

1 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel February 2013