wine-devel July 2016

46 participants
227 discussions

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer 22 Nov '20

22 Nov '20

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong 28 Sep '18

28 Sep '18

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird 14 Jun '18

14 Jun '18

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

Adding binfmt configuration to official Wine packages
by Bruno Jesus 23 Aug '16

23 Aug '16

Hi, I would like to please call for attention on bug https://bugs.winehq.org/show_bug.cgi?id=39884 As far as I understand there are only benefits to users if we allow .exe files to run through binfmt, would it pose any kind of problem to add this configuration to our packages? Best wishes, Bruno

6 19

Re: user32: Avoid -Wmisleading-indentation warnings and fix comments in comments in test_AppendMenu.
by Dmitry Timoshkov 11 Aug '16

11 Aug '16

Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > diff --git a/dlls/user32/tests/menu.c b/dlls/user32/tests/menu.c > index 33d8eb8..ea965cd 100644 > --- a/dlls/user32/tests/menu.c > +++ b/dlls/user32/tests/menu.c > @@ -3992,13 +3992,15 @@ static void test_AppendMenu(void) > mii.wID = 206; > ret = InsertMenuItemA(hmenu, 0, TRUE, &mii); > ok(ret, "InsertMenuItem failed\n"); > -if (0) /* FIXME: uncomment once Wine is fixed */ > +if (0) /* FIXME: enable once Wine is fixed */ { > check_menu_items(hmenu, 206, MF_SEPARATOR, MFS_GRAYED); > +} > mii.wID = 207; > ret = SetMenuItemInfoA(hmenu, 0, TRUE, &mii); > ok(ret, "SetMenuItemInfo failed\n"); > -if (0) /* FIXME: uncomment once Wine is fixed */ > +if (0) /* FIXME: enable once Wine is fixed */ { > check_menu_items(hmenu, 207, MF_SEPARATOR, MFS_GRAYED); > +} > DestroyMenu(hmenu); > > hbmp = CreateBitmap(1, 1, 1, 1, NULL); Please don't make the code look uglier than it already is. I'd personally argue that checking and forcing indentation rules by a C compiler is pretty disappointing and actually misleading. That warning should be turned off by default IMHO. -- Dmitry.

3 2

WineHQ upgrade breaking dinput8:dinput?
by Francois Gouget 07 Aug '16

07 Aug '16

This is a truly weird one. dinput8:dinput start failing on the 17th, the day after WineHQ was upgraded: https://test.winehq.org/data/tests/dinput8:dinput.html What makes this weird is that: * There has been no change to these tests between bd332f53f2d7 and 966a07149a02. In fact the last patch goes back to 2013. So it's not a bad patch. * The failures happen on every 32 bit test environment, from XP to Windows 10, VM or not, TestBot or not. Only 64 bit is spared. * I compiled a dinput8_crosstest.exe binary bd332f53f2d7 which was not failing according to the test.winehq.org results. But all I got is failures: - 887b445bb878, 8th, 0 test.winehq.org failures, 13 here: https://testbot.winehq.org/JobDetails.pl?Key=21611 - bd332f53f2d7, 16th, 0 test.winehq.org failures, 13 here: https://testbot.winehq.org/JobDetails.pl?Key=21610 - 329dfee70c35, 22nd, 13 test.winehq.org failures, 13 here https://testbot.winehq.org/JobDetails.pl?Key=21609 My MinGW compiler is more recent than the one WineHQ was using before the upgrade however. So I think this points to a compiler-related issue. The official WineTest binaries are build on WineHQ so I suspect the MinGW upgrade is somehow responsible for the new failures. However I don't know if the old compiler was masking them, of if the new one is causing them. Any ideas? For reference: * Debian Testing (my environment): $ i686-w64-mingw32-gcc --version i686-w64-mingw32-gcc (GCC) 5.3.1 20160205 * Debian 7 (close to former WineHQ environment): $ i686-w64-mingw32-gcc --version i686-w64-mingw32-gcc (GCC) 4.9.1 -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Nouvelle version : les anciens bogues ont été remplacés par de nouveaux.

5 15

Enabling/Disabling Joysticks from registry for the Mac
by DavidL 03 Aug '16

03 Aug '16

Hi Ken, I was looking into how the Linux-dinput code and joy.cpl work and comparing that to the macOS-dinput code. I have some questions about how best to proceed: joy.cpl uses joy->instance.tszInstanceName to name the joysticks in the control panel. In Linux-dinput code, they pass the joystick_devices[id].name to both tszInstanceName and tszProductName In the macOS-dinput code, they pass the name "Joystick #" where # is the index in the joystick array to the instance name and the joystick's actual name to the product name. When looking at the Microsoft guidelines for dinput, it does indeed say that the instance name *can* be joystick + position in the array, but doesn't specify that it *has* to be ( https://msdn.microsoft.com/en-us/library/windows/desktop/microsoft.directx_…). Also, I've confirmed that in the Windows 10 joystick control panel the joysticks are listed by their name, not by joystick number (and in my memory of earlier Windows OSes it's the same). So, should I change the macOS-dinput code to set both tszInstanceName and tszProductName to the product name (as in Linux) or should I change joy.cpl to use tszProductName instead of tszInstanceName? This will also make it easier in the registry to know which joystick is being enabled/disabled. Further, while joy.cpl correctly is a dinput control panel, enabling/disabling joystick should be for both dinput and winmm games - e.g. X-wing vs Tie Fighter even has the joystick control panel in the game's loader window*, but, once in the game, joystick control is handled by winmm. I believe the joystick registry entry is under dinput, but the winmm wine joystick driver should read that as well. Is it acceptable for wine joystick driver to read the dinput registry? Or should two registry entries be created? or should a single general joystick registry entry not under dinput or winmm control both? I may have more questions, but we'll start off with these. :) Cheers, David *Interestingly, the game's sequel X-wing: Alliance says I need to install DirectX to access joystick options in the loader window. I'm not sure why the older title brings up the joystick control panel just fine, but the later one does not.

2 2

wine-1.8.4-rc1
by Michael Stefaniuc 02 Aug '16

02 Aug '16

Hello guys, I have pushed wine-1.8.4-rc1 (with tag) to https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ Getting nearer to the goal of "around 50" commits for a stable release as this one contains only 66 commits. Nothing fancy though: - Stubs - More GPUs added - One wined3d fix backported (thanks again to Henri) - One original patch aka not cherry-picked, see below. Should somebody look at the release commit he'll notice that 7 of the bugs were already included in wine-1.8.3. That was a mistake as I had deferred those for a later release. So I've modified tools/make_announce to avoid that mistake in the future. For the release I would follow the same process: one week for feedback followed by another rc if needed with the final release 3-4 days later. Lets see how this works out as I'm on vacation travelling and Alexandre will travel too. And last but not least an excerpt from the ANNOUNCE file: What's new in this release (see below for details): - Various bug fixes. - A few more cards added to the GPU description table. ---------------------------------------------------------------- Bugs fixed in 1.8.4 (total 49): 18745 64-bit Mortal Kombat X crashes on unimplemented function KERNEL32.dll.GetLargePageMinimum 20977 Bad hlp table rendering 22819 Some applications like Heroes of Might and Magic 2 display loopback. 25396 Safrosoft RoX freezes at start. 26268 Multiple applications need ntdll.ZwSetLdtEntries stub (kwiksupport.me, Ragnarok Online patcher) 26965 Dragon Age 2 demo - sound in cutscenes is muffled 27680 Multiple 64-bit applications crash on startup (violation of the Windows 64-bit ABI, stack pointer (RSP) must be 16-byte aligned when making a call to Win64 API) 28082 OCCT Perestroïka needs hal.dll.READ_PORT_ULONG 34052 The Witcher: Character models are sometimes invisible 36556 valgrind shows a definite leak in comctl32/tests/syslink.c 36838 TOCA Touring Car Championship: installer copies one file from CD and then shows an error 37063 NTLM EncryptMessage/DecryptMessage failure 37090 Multiple applications crash with built-in amstream (Shogun: Total War, Medieval: Total War) 37271 Applications get IP address of 127.12.34.56 when lo0 is up on OSX 38102 Process Hacker 2.x needs winsta.dll.WinStationEnumerateW 38137 WBaduk: "Could not obtain OLE control window handle" regression 38811 Java JRE 8 installer 'jre-8uXX-windows-i586.exe' crashes on startup (GetThreadPreferredUILanguages is a stub) 38962 expr.c:234 and 235 attempted computation of 1 << 31 should be 1u << 31 39543 Multiple games and applications crash on unimplemented function KERNEL32.dll.FreeUserPhysicalPages (Microsoft Office 2007 diagnosis service, Eden Eternal) 39579 iNode 3.6 client needs ndis.sys.NdisAllocateMemoryWithTag 39842 Skype for windows doesn't work (needs ndis.sys.NdisSystemProcessorCount) 39911 dxd9 PresentationInterval not propagated on device Reset 39933 iNode 3.6 client needs ndis.sys.NdisAllocateSpinLock 40048 Camtasia Studio 8 : crashes on unimplemented function dwmapi.dll.DwmSetPresentParameters 40301 wxDatePickerCtrl (wxWidgets) generates an assert on DTM_GETRANGE message result 40380 Wine should take dosbox's configuration instead of creating a new one 40389 cmd.exe (native): Unimplemented function KERNEL32.dll.GetConsoleAliasExesLengthW 40487 3dmark Vantage Benchmark: unimplemented functions hal.dll.READ and WRITE PORT 40497 "Trainz: A New Era" needs msvcr120.dll.?__ExceptionPtrToBool@@YA_NPEBX@Z 40511 Application that copies files from one place to another stoped working in wine versions greater then 1.6.2 40532 Microsoft Word Viewer 11.8 does not show text on file properties dialog until the text is selected 40557 KSP Trajectory Optimization Tool (MATLAB Runtime (MCR)) crashes at launch 40562 AkelPad: [ToolBar plugin] tooltips for toolbar buttons have some extra text 40581 Regression: dsound input recording from microphone lags with 2 seconds delay 40614 Cisco Jabber 11.6 crashes due to missing dbghelp.dll.EnumerateLoadedModulesExW 40618 Autodesk 123D Design needs msvcr100.dll.mbsrtowcs_s 40659 Window with CS_OWNDC style cause DC leak when GetDC/ReleaseDC is used. 40691 DVDFab 9.2.4.4 pre-check FabCheck.exe executable fails, needs setupapi.dll.CM_Get_DevNode_Status 40745 Python 3.5.1 interpreter crashes, needs _set_thread_local_invalid_parameter_handler 40747 Microsoft Expression Web 4 crashes on startup, needs gdiplus.dll.GdipGetImageAttributesAdjustedPalette 40754 GOG Galaxy crashes with unimplemented function api-ms-win-crt-locale-l1-1-0.dll._lock_locales 40755 GOG Galaxy crashes with unimplemented function ucrtbase.dll._lock_locales 40756 GOG Galaxy crashes with unimplemented function api-ms-win-crt-heap-l1-1-0.dll._calloc_base 40770 Nvidia GeForce GT 730 not recognized properly 40796 Python 3.5.1 interpreter crashes when importing pyqtSlot 40830 Conflict between kVK_RightCommand and macOS 10.12 Sierra in carbon framework 40833 Batman: Arkham Origins Blackgate no sound during gameplay (except cutscenes) 40851 macOS 10.12 Build Failure in winspool.drv with cupsGetPPD 40923 Alone in the Dark (2008) crashes on launch with msvcrt assertion ---------------------------------------------------------------- Changes since 1.8.3: Alex Henrie (6): msvcrt: Stub out _(get|set)_thread_local_invalid_parameter_handler. ucrtbase: Implement _(un)lock_locales. ucrtbase: Implement _calloc_base. ucrtbase: Implement _malloc_base. ucrtbase: Implement _free_base. riched20: Don't call UpdateWindow after setting the background color. Alexandre Julliard (1): user32: Completely free owned DCEs when the corresponding window/class is destroyed. Alistair Leslie-Hughes (2): wininet: Free socket when connection is freed. wined3d: Correct memory size for Geforce 9600 GT. Andrew Eikum (3): dsound: Support downmixing 5.1 to stereo. dsound: Capture all available data on each period callback. xaudio2: Always set current OpenAL context before making AL calls. André Hentschel (1): ndis.sys: Implement NdisSystemProcessorCount. Austin English (12): hal: Add READ_PORT_ULONG stub. hal: Add READ_PORT_UCHAR stub. hal: Add WRITE_PORT_ULONG stub. kernel32: Add FreeUserPhysicalPages stub. winsta: Add a stub for WinStationEnumerateW. dwmapi: Add DwmSetPresentParameters stub. kernel32: Add GetConsoleAliasExesLengthA/W stubs. ntdll: Add NtSetLdtEntries/ZwSetLdtEntries stub. dbghelp: Add forwards for EnumerateLoadedModulesEx/EnumerateLoadedModulesExW. kernel32: Implement GetLargePageMinimum. ndis.sys: Add NdisAllocateMemoryWithTag stub. ndis.sys: Add NdisAllocateSpinLock stub. Benjamin Hodgetts (1): wined3d: Add Intel Iris chips to identification list. Bruno Jesus (1): ws2_32: Ensure default route IP addresses are returned first in gethostbyname. Béla Gyebrószki (2): wined3d: Add Nvidia GeForce GTS 250. wined3d: Add Nvidia GeForce GT 730 (GK208). David Woodhouse (1): secur32: Fix handling of ANSI NTLM credentials. Fabian Maurer (1): msacm32: Added converter for ADPCM to PCM 8 bit mono. Grazvydas Ignotas (3): wined3d: Use Intel data returned by Windows driver. wined3d: Add some more Intel GPUs. wined3d: Add a fallback for Skylake. Hans Leidekker (1): kernel32: Improve the stub for GetThreadPreferredUILanguages. Henri Verbeet (1): wined3d: Also update the swap interval when not recreating the context in wined3d_device_reset(). Jarkko Korpi (1): widl: Fix overflow when left-shifting. Jean-Christophe Cardot (6): winhlp32: Replace magic numbers by symbols. winhlp32: Add some trace calls. winhlp32: Add a warning trace. winhlp32: Prepare winhlp32 for more font types. winhlp32: Rework and rename HLPFILE_HalfPointsToTwips. winhlp32: Fix table formatting. Justas Lavišius (1): include: Force stack alignment on x86_64. Ken Thomases (2): winspool.drv: Include <cups/ppd.h> to fix building against the macOS 10.12 SDK. winemac: Don't define kVK_RightCommand when building against the macOS 10.12 SDK. Luis Sahagun (1): winevdm: Tell dosbox to read the current user's config. Matteo Bruni (1): wined3d: Add a setting to check relative addressing indices when accessing uniforms. Michael Müller (1): amstream: Implement IDirectDrawMediaStream::GetMultiMediaStream. Michael Stefaniuc (1): tools: Get the bug list for ANNOUNCE from the stable-notes git notes. Nikolay Sivov (2): comctl32/datetime: Use MCM_GETRANGE result directly in DTM_GETRANGE. comctl32/tooltips: Cut tooltip text at first tab char unless TTS_NOPREFIX is used. Olivier F. R. Dierick (1): shell32: Set last error explicitly in SHFileOperation(). Piotr Caban (6): msvcrt: Add mbsrtowcs_s implementation. msvcp110: Fix num_put<char> structure layout. msvcrt: Fix mbtowc behavior for buffers containing more than one character. ieframe: Restore closed IOleClientSite in DoVerb. msvcr120: Add __ExceptionPtrToBool implementation. msvcrt: Return error when previously parsed type is accessed while demangling simple data type. Rob Walker (1): setupapi: Add stub for setupapi.dll.CM_Get_DevNode_Status. Sebastian Lackner (3): comctl32/syslink: Fix a blocks leak (Valgrind). amstream/tests: Add tests for GetMultiMediaStream methods. server: Fix assignment of primary_group in token_duplicate. Stefan Leichter (3): kernel32: Add stub for GetSystemPreferredUILanguages. kernel32/tests: Add tests for GetSystemPreferredUILanguages. kernel32: Return a dummy value in GetSystemPreferredUILanguages. Vincent Povirk (1): gdiplus: Implement GdipGetImageAttributesAdjustedPalette. bye michael -- Michael Stefaniuc mstefani(a)winehq.org

3 3

Wine's forked version of fontforge
by Jens Reyer 01 Aug '16

01 Aug '16

Hi, in Debian we're currently moving to enable the maintainer mode to e.g. rebuild Wine's TrueType fonts. AJ already warned us that this is risky: On 04/01/2016 04:54 AM, wine-bugs(a)winehq.org wrote: > https://bugs.winehq.org/show_bug.cgi?id=40391 > > --- Comment #3 from Alexandre Julliard <julliard(a)winehq.org> --- > There is definitely a risk too, particularly for fonts. They are supposed to be > built with our forked version of fontforge > (https://source.winehq.org/git/fontforge.git), that contains a couple of fixes > compared to the upstream version. I really appreciate that warning, thanks again! See a "short" explanation at the end of the mail, why we want to do this anyway. I'd like to figure out how to improve the resulting situation by getting the Wine changes to fontforge applied upstream (and/or in Debian). With "upstream" I mean github.com/fontforge. I will contact them in a later step. Wine and Debian are both using the quite old fontforge version 20120731-b, the patches apply cleanly in Debian. But upstream is actively developing and in Debian someone is working on packaging a recent version (not sure with what outcome, e.g. afaik there is at least one upstream regression blocking an update). Are there any plans in Wine to update to a newer version? Wine's fontforge has 4 changes. I recreated them based on AJ's merge for 20120731-b and by myself for 20160404 to get a *rough* picture of their current state (not tested and I'm absolutely no expert in this): 1. Various hacks to avoid putting timestamps in generated files (AJ). No relevant changes upstream, but there is some work going to allow one to specify the timestamp in order to get the build deterministic/reproducible. Would this make this patch obsolete? I don't know why upstream wants timestamps at all, nor what problems these cause for Wine. Is this Wine specific, or would it make sense to drop timestamping upstream, too? 2. - Avoid outputting trailing spaces in sfd files (AJ). About a third seems to be applied in 20160404. I assume the rest would still be relevant if Wine updated its fontforge version. Is this patch only relevant for creating fonts/glyphs, but not for building the TrueType fonts? Looks like a good candidate for forwarding to upstream. 3. Enable the width of individual bitmap strikes to be altered (Huw Davies). Since the import of upstream version 20120731-b this patch only has a third of its original size. Are the remaining Wine changes still necessary, or are they cruft? If still needed, I guess they should be pushed upstream. In 20160404 not much seems to have changed, but the containing file bitmapview.c was moved ("splitting ui code from fontforge/ to fontforgeexe/"). Same as above: is this only needed when creating fonts? Looks like a candidate for upstream. 4. Don't save the selected state. (Huw Davies) I found no relevant changes upstream. No idea about this. Why are we doing this? ---------------------- The Debian Free Software Guidelines [DFSG] (which are the fundamental basis for the Debian project) mandate that binaries must be accompanied by their source (which is usually ensured by building from source), and that you must be able to modify and redistribute the package with only the software available in Debian. The reasons for these are e.g. philosophical (empowering the user), QA (rebuilding if there was an issue in the build tools), reproducibility (recreate byte-by-byte-identically, e.g. to rule out attacks at a build machine or do QA) or security (a build from correct source code may be manipulated by specific compilers). The TrueType fonts are pre-built with a forked fontforge, which isn't (and very unlikely will ever be) in Debian. To package the pre-built fonts imo we would have to remove Wine from official Debian (main), and move it to the non/semi-official contrib section. For the same reason (AFAIK, I'm not the author of these changes) we're also regenerating opengl files, request code and unicode. This problem was ignored/missed in the past for the Debian Wine packages, yet this is no argument against fixing them now. We definitely don't want Wine removed from Debian, instead keep it in and get it there as good as possible. btw, we're also adding a patch (based on wine staging) to append '(Debian)' to the version string now. btw2, can you recommend some alternative free fonts to install (either as partial replacement or as extension to the Wine fonts)? Greets, and thanks in advance jre [DFSG] https://www.debian.org/doc/debian-policy/ch-archive.html#s-dfsg, see also the following chapter "The main archive area".

2 3

Re: [2/3] wininet: Start the first chunk as soon as we have some data.
by Jacek Caban 01 Aug '16

01 Aug '16

Hi Hans, On 19.07.2016 11:27, Hans Leidekker wrote: > Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> > --- > dlls/wininet/http.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c > index 2c62d97..c4cf66b 100644 > --- a/dlls/wininet/http.c > +++ b/dlls/wininet/http.c > @@ -2921,6 +2921,7 @@ static DWORD set_content_length(http_request_t *request) > !strcmpiW(encoding, szChunked)) > { > chunked_stream_t *chunked_stream; > + DWORD res; > > chunked_stream = heap_alloc(sizeof(*chunked_stream)); > if(!chunked_stream) > @@ -2935,6 +2936,12 @@ static DWORD set_content_length(http_request_t *request) > memcpy(chunked_stream->buf, request->read_buf+request->read_pos, request->read_size); > chunked_stream->buf_size = request->read_size; > request->read_size = request->read_pos = 0; > + > + res = start_next_chunk(chunked_stream, request); > + if (res != ERROR_SUCCESS) { > + heap_free(chunked_stream); > + return res; > + } It seems to me that you're fixing a problem is a wrong place. start_next_chunk should be called by HTTP_ReceiveRequestData via refill_read_buffer anyway. I'd suggest to investigate why it doesn't work in your case. Also, see the attached test. We shouldn't need any chunk to complete requests. It's an existing problem in current Wine, which may be unrelated to your problem, but having such blocking calls here is not a step in the right direction. Thanks, Jacek

2 2

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel July 2016