wine-devel July 2023

12 participants
10 discussions

Mailing list traffic
by Francois Gouget 19 Apr '24

19 Apr '24

With GitLab and the spinning off of commit messages to wine-gitlab I think the traffic estimates on the mailing list page need to be updated... at least for wine-devel: it no longer has 50 messages per day. https://www.winehq.org/forums (unfortunately there is no unit on the little per mailing-list graph) -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Theory is where you know everything but nothing works. Practice is where everything works but nobody knows why. Sometimes they go hand in hand: nothing works and nobody knows why.

4 3

The future of WineConf
by Alexandre Julliard 27 Jan '24

27 Jan '24

Folks, As you may have noticed, we haven't been making any plans for WineConf this year. Jeremy has been busy preparing his retirement, and I haven't been pushing it either, mostly because I'm not convinced that we want to continue the traditional WineConf model. Even though we skipped a few years because of the pandemic, attendance at last year's WineConf wasn't great. We also suggested meeting at FOSDEM in February, like we did in previous years, but essentially no one showed up. So I'm wondering whether there is still enough interest for a traditional WineConf, or whether we should try a different approach, to maybe capture some of the recent excitement around gaming and downstream uses of Wine in general. I'd like to hear your thoughts. Should we do a Proton conference, or join some kind of gaming-related event? Do people even want to travel to conferences anymore? What kind of event would you be interested in, particularly those of you who don't show up to the traditional WineConf? -- Alexandre Julliard julliard(a)winehq.org

14 19

TestBot News - MR false positives analysis
by Francois Gouget 19 Oct '23

19 Oct '23

I have been reviewing the TestBot and GitLab CI test results for the merged MRs. While doing that I updated the TestBot's known failures list (https://testbot.winehq.org/FailuresList.pl) in order to drive down the false positive rate. Incidentally I also collected the list of test units causing false positives, so I'll start with that. Specifically, here are the bugs to fix to help the GitLab CI: * Bug 53433 - mmdevapi:capture - impacted 18 MRs * Bug 54064 - ntdll:threadpool - impacted 15 MRs * Bug 54078 - ntdll:pipe - impacted 11 MRs * Bug 54140 - mmdevapi:render - impacted 5 MRs * Bug 54005 - ole32:clipboard - impacted 5 MRs * Bug 54037 - user32:msg - impacted 5 MRs * Bug 54074 - ws2_32:sock - impacted 5 MRs I classified the TestBot / GitLab CI results as follows: * False positive Cases where the CI system incorrectly claimed the MR introduces new failures. This is typically the case when the failures that are already present in nightly WineTest results. * Bad merge MRs that break a test and got merged anyway. * Collateral Damage from a bad merge The false positives (aka collateral damage) caused by one of the bad merges above. * Outside interference This identifies false positives that are not random and intrinsic to the test but that result from change outside the Wine infrastructure, for instance certificates that expire, or configuration changes to servers that break the tests that depend on it. Of those the only ones that a CI can really avoid are the first type, aka "False positive". So I calculated the corresponding weekly rate: Adjusted False Positive rate Week | TestBot | GitLab CI 2022-11-14 | 21.9% | 8.3% 2022-11-21 | 8.0% | 21.6% 2022-11-28 | 14.7% | 28.4% 2022-12-05 | 8.5% | 24.5% 2022-12-12 | 0.0% | 20.0% Note that the TestBot's 8% rate for the 11-21 week is not representative because Wine was broken that week (collateral damage) which prevented the tests from running in Wine, and thus from contributing real "false positives". Also the 12-12 week is still incomplete obviously. Even so I think his shows the TestBot is improving. Here's a list of the incidents for the weeks above: * 11-14 An external certificate revocation issue caused crypt32:cert to fail systematically. This impacted 14 merge requests and was fixed in MR1360. * 11-17 MR!1399 got merged despite the TestBot detecting that it prevented 32-bit Wine tests from running to completion. This impacted 39 merge requests. I could have reduced that number if I had been faster to reconfigure the TestBot to stop running the full 32-bit Wine test suite. This was fixed in MR!1524. * 11-17 MR!1398 got merged despite the TestBot detecting that it broke ntoskrnl.exe:ntoskrnl on Windows 7. This was fixed in MR!1803. * 11-22 MR!1495 got merged despite the TestBot detecting that it broke vbscript:run on Windows *. I don't have a record of the impacted MRs or of when it was fixed. * 11-23 The b00a831d direct commit broke kernel32:process in Wine. This got fixed since. * 12-07 MR!1732 got merged despite the TestBot detecting that it broke taskschd:scheduler on Windows *. I immediately added a known failure entry and no MR got impacted. This was fixed in MR!1736. If not filtering out the failures caused by these incidents, the false positive rate is: Raw False Positive rate Week | TestBot | GitLab CI 2022-11-14 | 52.1% | 27.1% 2022-11-21 | 50.0% | 29.5% 2022-11-28 | 20.0% | 33.7% 2022-12-05 | 19.1% | 57.4% 2022-12-12 | 0.0% | 20.0% I think that also shows that the TestBot is improving. I have attached the raw data I collected and shell snippets to extract various statistics (failures-mr.txt) as well as a spreadsheet import (failures.xls). -- Francois Gouget <fgouget(a)codeweavers.com>

1 5

Vacations
by Alexandre Julliard 25 Jul '23

25 Jul '23

Folks, I'll be out on vacation for about 3 weeks starting today. I'm still planning to review and commit merge requests, but the timing will be slower and more random than usual. I'll also skip the August 4 release, so Wine 8.14 will be out on August 18. Have fun while I'm gone ;-) -- Alexandre Julliard julliard(a)winehq.org

1 0

Wine-CE 8.13 released
by fanwj＠mail.ustc.edu.cn 23 Jul '23

23 Jul '23

Wine-CE 8.13 released! Address: https://gitlab.com/wine-ce/wine-ce/-/releases/v8.13 Wine-CE (Chimera Edition, Cross-architecture Emulator) is a compatibility layer capable of running Windows applications on Cross-architecture paltform of Linux. It is base on Wine Project and Qemu Project ChangeLog: 1. Add GLES backed for wined3d. 2. Add EGL supported for winex11.drv 3. New 32-bit allocation for wow64

1 0

Wine staging 8.13 release
by Alistair Leslie-Hughes 23 Jul '23

23 Jul '23

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 8.13 (504 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * None Added: * [55135] d3d12core: Add D3D12GetInterface stub. Updated: * vkd3d-latest to latest. * windows.networking.connectivity-new-dll Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

wine-8.0.2-rc1 Available
by Michael Stefaniuc 09 Jul '23

09 Jul '23

Hello, I have pushed wine-8.0.2-rc1 (98639f1859ba614e7ca8cfbc41fa7e9fcc603240) with tag to https://gitlab.winehq.org/mstefani/wine/-/tree/stable https://people.redhat.com/mstefani/wine/stable/ And created the merge request https://gitlab.winehq.org/wine/wine/-/merge_requests/3168 The merge request is no longer a draft as that confused some reviewers as meaning "not finished". But I still intend to give people at least 1 week time to comment on it. I will just hold off my own approval for the MR. What's new in this release: - Various bug fixes ---------------------------------------------------------------- Bugs fixed in 8.0.2 (total 27): - #11436 Pepakura viewer: err:wgl:X11DRV_wglShareLists Could not share display lists, context already created ! - #35254 Freemake Video Converter 4.1 installer complains about running Freemake processes (builtin 'findstr' stub app always returns "match") - #49964 32-bit dxdiag doesn't support '/64bit' command line switch (launch 64-bit dxdiag) - #51178 The Bat! v9.3.4.12: Missing content in TTreeViews on Windows versions higher than 8 - #52322 wineserver memory leak during HTTPs download (Genshin Impact Launcher, Qt5) - #53073 mfplat: unimplemented function while loading Devil May Cry 1 - #53704 Bible Black ~La Noche de Walpurgis~ won't start - #53781 Multiple apps crash on unimplemented function CFGMGR32.dll.CM_MapCrToWin32Err (Matrix Awakens MegaCity Unreal Engine 5.1 demo, Hogwarts Legacy) - #53794 Sins of the Solar Empire Rebellion (Gog 1.975.1) crashes on unimplemented function concrt140.dll.?_CheckTaskCollection@_UnrealizedChore@details@Concurrency@@IAEXXZ - #53826 Attempting to install / update battle.net fails with Qt error - #53983 Chromium broken sandbox, needs NtQueryInformationProcess with ProcessHandleTable - #54110 CubicSDR crashes on unimplemented function msvcp140.dll.?_Rethrow_future_exception@std@@YAXVexception_ptr@1@@Z - #54618 VARA FM crashes on unimplemented function pdh.dll.PdhVbGetDoubleCounterValue - #54640 Treecomp listviews and possibly other widgets are not drawn - #54675 Chocolatey OpenSSH installer fails - #54687 LibreVR Revive fails to run (CertGetNameStringW with dwType=CERT_NAME_ATTR_TYPE and pvTypePara missing additional fallbacks) - #54702 ldp.exe crashes when attempting to add, delete, modify, or compare an entry without a name - #54724 LDAP bind over SSL to a server and port that do not support SSL hangs forever - #54728 Pro Evolution Soccer 2008 demo takes +- 9 minutes to complete extracting 'Pro Evolution Soccer 2008 DEMO.msi' (disabling 'Light' theme works around) - #54733 Notepad3 crashes on unimplemented function SHLWAPI.dll.StrFormatByteSizeEx - #54799 wininet:internet - test_InternetGetConnectedStateExA() fails in the Japanese and Chinese locales in Wine - #54808 Access violation in ntdll when running Adolix Split and Merge PDF with .NET Framework installed - #54819 DnsQuery_A() mishandles CNAME DNS records - #54882 Conemu fails to start (cannot attach to process) - #54939 Dotted files are shown - but "don't show dotted" files is active - #54960 winhttp:winhttp - test_websocket() fails on Windows and Wine - #55008 wininet:http - test_secure_connection() fails on Windows and Wine ---------------------------------------------------------------- Changes since 8.0.1: Alex Henrie (12): comctl32/treeview: Ignore the lParam to WM_PRINTCLIENT and add tests. wldap32: Handle null DN or null message in ldap_add* and add tests. wldap32: Handle null DN or null message in ldap_modify* and add tests. wldap32: Handle null DN or null attr in ldap_compare* and add tests. wldap32/tests: Use the same context in test_ldap_(add|modify_compare). wldap32: Handle null DN or null message in ldap_delete* and add tests. winex11: Simplify confusing condition and error messages in wglShareLists. opengl32/tests: Make the wglShareLists tests comprehensive. winex11: Allow replacing either context in wglShareLists. kernel32/tests: Check that lpSectionBase != NULL before dereferencing. ntdll: Increment offset by len in build_clr_surrogate_section. winemenubuilder: Skip desktop integration for certain associations. Alexandre Julliard (3): kernelbase: Move to a higher address on 64-bit. ntdll: Fix typo in the check for hidden files. wininet/tests: Update expected WineHQ certificate. Alistair Leslie-Hughes (1): activeds: Free memory on error paths (coverity). Bernhard Übelacker (1): ntoskrnl: Do not leak memory by setting input buffer to NULL. Biswapriyo Nath (2): include: Fix c++ compiler error with msxml2.idl. include: Fix IDirectXVideoDecoderService declaration in dxva2api.idl. Brendan Shanks (7): include/msvcrt: Add __WINE_(DEALLOC|MALLOC) attributes to _strdup and _wcsdup. msvcrt: Fix crash when rethrowing after a non-C++ exception on x86_64. winemac: Fix memory leak in UpdateDisplayDevices. winemac: Refactor constrain_window_frame() to use separate origin and size arguments. winemac: Set the Cocoa window contentMaxSize to the size limits from constrain_window_frame(). winemac: Don't constrain surface dimensions to the onscreen part of a window. winemac: Initialize retina_on to avoid incorrect cached display data in high-res/retina mode. David Kahurani (1): shlwapi: Implement StrFormatByteSizeEx. Eric Pouech (3): winedbg: Don't crash when no search path has been set. evr: Fix incorrect integral computation. winedump: Fix out of bounds access (spotted by GCC13). François Gouget (2): wininet/tests: Dump the state string if it is not as expected. wininet: InternetGetConnectedStateExA() must always null-terminate the state string. Gabriel Ivăncescu (8): mshtml: Fix nsevent leak in create_document_event. mshtml: Fix nsscript leak in bind_event_scripts. mshtml: Fix nsuri leak if create_channelbsc failed. mshtml: Fix nsparser leak if script_elem_from_nsscript failed. mshtml: Fix factory leak in init_nsio. mshtml: Fix nsIFile dir leak in init_xpcom. mshtml: Fix URI leak in NewURI on failure. mshtml: Store minimum compat mode required for events in the ctor table. Hans Leidekker (3): ldap: Return an error when the server doesn't respond to the SSL handshake. ws2_32: Skip non-address records in dns_only_query(). winhttp/tests: Fix a test failure. Jactry Zeng (1): wordpad: Resize buttons of toolbar to make them align with height of the font list combox. Jinoh Kang (2): kernel32/tests: Test for manifest file open share mode in CreateActCtxW. ntdll: Open application manifest files with FILE_SHARE_DELETE. Louis Lenders (1): wine.inf: Add EditionID to HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion. Michael Stefaniuc (2): dmsynth: Don't crash when Open() gets a DMUS_PORTPARAMS7. threadpoolwinrt: Forward a Release() to a Release() method. Mohamad Al-Jaf (4): pdh: Implement PdhVbGetDoubleCounterValue(). pdh/tests: Add PdhVbGetDoubleCounterValue() tests. cfgmgr32: Implement CM_MapCrToWin32Err. cfgmgr32/tests: Add CM_MapCrToWin32Err tests. Nikolay Sivov (1): mfplat: Implement MFCreatePathFromURL(). Olivier F. R. Dierick (1): dxdiag: Ignore option /64bit on the commandline. Paul Gofman (2): ntdll: Add stub for NtQueryInformationProcess( ProcessHandleTable ). ntdll: Avoid integer overflow in block_get_subheap(). Piotr Caban (1): localspl: Don't pass original document name to cupsStartDocument. Sven Baars (1): wine.inf: Put the Clients key in the right place. Tim Clem (1): winemac.drv: Force a window in front of its peers if its level is decreased. Torge Matthies (4): ntdll/tests: Add test for file attributes of files with names beginning with a dot. ntdll: Handle hidden file names inside get_file_info instead of after it. ntdll: Only infer hidden attribute from file name if xattr is not present. ntdll: Set xattr in NtCreateFile if inferred and requested attributes don't match. Tyson Whitehead (2): crypt32: Add some CertGetNameStringW fallback cases. crypt32/tests: Test for CertGetNameStringW fallback cases. Vijay Kiran Kamuju (2): msvcr100: Add _UnrealizedChore::_CheckTaskCollection stub. msvcp110: Add std::_Rethrow_future_exception implementation. Zebediah Figura (1): ntdll: Make fd_set_file_info() static. Zhiyi Zhang (4): light.msstyles: Use border fill background for progress parts. light.msstyles: Don't draw a border for progress fill parts. findstr: Add basic functionality. wined3d: Add GPU information for AMD Raphael. Ziqing Hui (1): mfreadwrite: Fix an address of operator typo. bye michael

1 0

Wine staging 8.12 release
by Alistair Leslie-Hughes 09 Jul '23

09 Jul '23

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 8.12 (504 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * wined3d: rename shader_extract_from_dxbc to wined3d_shader_extract_from_dxbc Added: * [55205] dinput: Improve keyboard devices scancode support. Updated: * vkd3d-latest to lateset. Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. * Suggest patches to be included in staging. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Code guidelines
by Alex Henrie 08 Jul '23

08 Jul '23

Hello everyone, I just finished rewriting the Wine coding guidelines based on feedback at <https://gitlab.winehq.org/wine/wine/-/merge_requests/3059>. Please look it over and let me know if there's anything that I missed or misstated: https://wiki.winehq.org/Submitting_Patches#Code_guidelines https://wiki.winehq.org/Wine_Developer's_Guide/Coding_Practice Thanks to Zeb and Alexandre in particular for the clarifications about style and compatibility. -Alex

1 0

GitLab notification emails stopped
by Alex Henrie 05 Jul '23

05 Jul '23

Hi, There was activity today on multiple merge requests that I was subscribed to, but I didn't get any notification emails. Is it just me, or have they stopped for everyone? -Alex

3 3

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel July 2023