[Bug 669] Changed - Illegal C characters from the program name are not filtered while creating the spec.c file
wine-bugs at winehq.com
wine-bugs at winehq.com
Sun May 12 23:09:41 CDT 2002
http://bugs.winehq.com/show_bug.cgi?id=669
*** shadow/669 Sun May 12 21:16:30 2002
--- shadow/669.tmp.6558 Sun May 12 23:09:40 2002
***************
*** 57,59 ****
--- 57,84 ----
------- Additional Comments From fgouget at codeweavers.com 2002-05-12 21:16 -------
Can you provide more details as to why it fails?
+
+
+ ------- Additional Comments From vberon at mecano.gme.usherb.ca 2002-05-12 23:09 -------
+ In the compilation of GCI-tool.spec.c:
+ gcc -c -I. -I. -I../../include -I../../include -g -O2 -Wall
+ -mpreferred-stack-boundary=2 -fPIC -DSTRICT -DNONAMELESSUNION -DNONAMELESSSTRUCT
+ -D_REENTRANT -I/usr/X11R6/include -o GCI-tool.spec.o GCI-tool.spec.c
+ GCI-tool.spec.c:185: parse error before `-'
+ GCI-tool.spec.c:189: parse error before `&'
+ GCI-tool.spec.c:189: warning: type defaults to `int' in declaration of
+ `__wine_dll_register'
+ GCI-tool.spec.c:189: warning: data definition has no type or storage class
+
+ Here's the excerpt of the file causing this:
+ void __wine_spec_GCI-tool_init(void)
+ {
+ ^ problem here
+
+ The function is called in an asm section just before. I'm not familiar enough
+ with it to know if the same function name is legal in asm or not.
+
+ My point of an executable starting with a number is moot, as a number in the
+ middle of the function name would be ok. But there still exist other characters
+ which are legal in a filename and illegal in a C identifier. Either throw them
+ out of the function name (completely or replaced by _), or document that fact.
\ No newline at end of file
More information about the wine-bugs
mailing list