[Bug 2891] Tooltip window steals focus and creates a "normal" window

Wine Bugs wine-bugs at winehq.org
Mon Oct 3 16:26:17 CDT 2005


http://bugs.winehq.org/show_bug.cgi?id=2891





------- Additional Comments From xerox_xerox2000 at yahoo.co.uk  2005-03-10 16:26 -------
Ok , that quick hack is bogus; the best i can come up with now is:

--- dlls/x11drv/window.c       2005-08-22 09:14:21.000000000 +0000
+++ dlls/x11drv/window.c       2005-10-04 23:22:29.000000000 +0000
@@ -120,12 +120,8 @@
  * Fill the window attributes structure for an X window.
  */
 static int get_window_attributes( struct x11drv_win_data *data,
XSetWindowAttributes *attr )
-{
-    if (!data->managed && !using_wine_desktop && is_window_managed( data->hwnd ))
-    {
-        data->managed = TRUE;
-        SetPropA( data->hwnd, managed_prop, (HANDLE)1 );
-    }
+{if(!using_wine_desktop && is_window_managed( data->hwnd ))
+    SetPropA( data->hwnd, managed_prop, (HANDLE)1 );
     attr->override_redirect = !data->managed;
     attr->colormap          = X11DRV_PALETTE_PaletteXColormap;
     attr->save_under        = ((GetClassLongW( data->hwnd, GCL_STYLE ) &
CS_SAVEBITS) != 0);

This fixes the problem, but i don't know if it breaks other apps. Funnily enough
it also seems to fix a bug in another pokerclient bug 2418. Anyway, i did a
regression test and the patch that causes the "broken tooltips" is 
http://cvs.winehq.org/patch.py?id=15839

Maybe someone more familiar with the code could have a look at it.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the wine-bugs mailing list