[Bug 3370] WM_SETICON does not change the window icon

Wine Bugs wine-bugs at winehq.org
Mon Jun 12 08:10:53 CDT 2006


------- Additional Comments From juris.smotrovs at sets.lv  2006-12-06 08:10 -------
Created an attachment (id=2618)
 --> (http://bugs.winehq.org/attachment.cgi?id=2618&action=view)
Patch enabling correctly setting application icon in WM

Craig, can you test whether this patch corrects your problem?
At least it solves mine which seems to be the same: Wine icon shows in window
manager caption and task bar instead of the application icon.

The problem is that, even though, at WM_SETICON the correct icon is set, a bit
later X11DRV_set_wm_hints resets the icon black to class default.
It seems that X11DRV_set_wm_hints was originally designed to be called only
when creating a new window: it allocates icon hints instead of getting the
existing ones, and sets the class default as the initial icon.
However, later X11DRV_set_wm_hints calls have been added at window mapping and
style change. Thus icon is reset to class default each time the window is
mapped or its style changed.

My patch checks whether an icon has already been set for the window, and in
such case does not reset the icon to class default. (The icons are set with
WM_SETICON via another x11drv function X11DRV_SetWindowIcon.)

Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the wine-bugs mailing list