[Bug 6589] Proposal to change the return value of the GraphBuilder_FindFilterByName (filtergraph.c file, quartz.dll)

Wine Bugs wine-bugs at winehq.org
Thu Nov 2 15:14:41 CST 2006


http://bugs.winehq.org/show_bug.cgi?id=6589





------- Additional Comments From mikolaj.zalewski at gmail.com  2006-02-11 15:14 -------
I'm afraid on one maintains the quartz.dll as it seems the last updates were
more than one year ago (but maybe I'm wrong and someone will correct me). The
MSDN also can't be 100% trusted as sometimes it's wrong.

The best way it to write a test case and it seems to be easly doable in this
case. Try to compile the quartz test under Windows (#define STANDALONE if you
want to compile only one file) add some function that runs (if I understand it
right):

... create an GraphBuiler ...
ret = IGraphBuilder_FindByName(iface, some garbage name, &out);
ok(ret == VFW_E_NOT_FOUND, "IGraphBuilder_FindByName returned %x, expected
VFW_E_NOT_FOUND", ret);
.. release the GraphBuilder ...

If it passed under Windows change the return value so that it passes under wine.
Then create a patch with both the test and the change and send it to
wine-patches at winehq.org . If the patches meets all the formal requirements I'd
expect it will be commited to the wine Git and will appear on
http://www.winehq.org/pipermail/wine-cvs/2006-November/thread.html .

Some requirements for patches are on http://www.winehq.org/site/sending_patches
. Another you might need to know for this patch is that in wine you must not use
L"Text" to create a widecharacter string as this don't work on some old
compilers. Instead need to declare the string as WCHAR string[] =
{'T','e','x','t',0}.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the wine-bugs mailing list