[Bug 10809] Directory selection broken in 16-bit File dialog

wine-bugs at winehq.org wine-bugs at winehq.org
Wed Dec 19 09:59:17 CST 2007


Alex Villacís Lasso <a_villacis at palosanto.com> changed:

           What    |Removed                     |Added
Attachment #9684 is|0                           |1
           obsolete|                            |

--- Comment #13 from Alex Villacís Lasso <a_villacis at palosanto.com>  2007-12-19 09:59:16 ---
Created an attachment (id=9695)
 --> (http://bugs.winehq.org/attachment.cgi?id=9695)
Fix for regression in DlgDirList

Recent fixes to LB_DIR behavior for returned value caused a regression in the
DlgDirList[A|W] function. The fix for LB_DIR aimed to comply to the documented
and tested behavior that it should return the last inserted index. Since the
listbox indexes are 0-based, this implies that in the case that LB_DIR inserts
nothing, it should return -1. Unfortunately, DlgDirList[A|W] took this -1 as a
fatal error and stops filling entries, causing the regression. This patch fixes
the regression and adds tests showing that the LB_DIR behavior is actually
correct, and also tests DlgDirList for the fixed behavior.

Patch already sent to wine-patches.

* DlgDirList should not stop filling listbox if one category does not return
any files in LB_DIR
* Tests showing that LB_DIR behavior is already correct for wildcard that does
not match any files.
* Tests showing DlgDirList behavior for wildcard that does not match any files,
including fixed behavi

Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

More information about the wine-bugs mailing list