[Bug 8936] openCanvas does not start properly

wine-bugs at winehq.org wine-bugs at winehq.org
Thu Dec 27 08:20:14 CST 2007


--- Comment #29 from Alex Balut <alexandru.balut at gmail.com>  2007-12-27 08:20:13 ---
Thanks! Please make sure that when you cd to tests and run "make test" it runs.

Some minor comments:

- is math.h needed?
- would be nice to have a single test instead of two, use strncmp, otherwise
use rc = *ret[...
- add a comment to the function instead of that trace call inside the function,
this is just a minor test

- "1 string terminator" instead of "1 endline"

- you could include the other change I mentioned, about DUMPCONTEXT, it's
really small

Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

More information about the wine-bugs mailing list