[Bug 6992] Vector NTI installer fails with "this module is not designed for direct execution"

[Wine Bugs]

http://bugs.winehq.org/show_bug.cgi?id=6992





------- Additional Comments From mk144210 at bcm.tmc.edu  2007-04-02 01:13 -------
I have fixed this bug. I attached the patch and will submit it to wine-patches.
It is a simple one-line change:

--- a/dlls/msi/action.c
+++ b/dlls/msi/action.c
@@ -642,7 +642,7 @@ UINT MSI_InstallPackage( MSIPACKAGE *pac
     msi_apply_transforms( package );
     msi_apply_patches( package );
 
-    if ( msi_get_property_int(package, szUILevel, 0) >= INSTALLUILEVEL_REDUCED 
)
+    if ( (msi_get_property_int(package, szUILevel, 0) & INSTALLUILEVEL_FULL) >=
 INSTALLUILEVEL_REDUCED )
     {
         package->script->InWhatSequence |= SEQUENCE_UI;
         rc = ACTION_ProcessUISequence(package);

Basically, the current code was not taking into account the flags like
INSTALLUILEVEL_SOURCESONLY (=0x100) and was taking anything that had these
flags to be a full UI install. The Vector NTI installer MSI files were
INSTALLUILEVEL_NONE (=2) | INSTALLUILEVEL_SOURCEONLY (0x100) = 0x102 and thus
wine was thinking it was a full ui level install because it was just seeing
if the UI level is greater than reduced UI level, rather than just taking the
part of the UI level value that refers just to the actual UI level without the
flags.

Unfortunately it seems like the installation of Vector NTI with the wine
MSI, although now seems to install most things, is still not complete (but
this error is gone). I will have to look at the further logs of the install now.

Misha

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.