[Bug 7571] Accented character glyphs are mixed up with TrueType fonts (affects e.g. Lotus Notes R5)

Wine Bugs wine-bugs at winehq.org
Mon May 21 23:14:51 CDT 2007


http://bugs.winehq.org/show_bug.cgi?id=7571





------- Additional Comments From dmitry at codeweavers.com  2007-21-05 23:14 -------
In general, this patch is much better, but needs some cleanup.
 
>      if (enum_gdi_fonts)
>          ret = WineEngEnumFonts( plf, FONT_EnumInstance, (LPARAM)&fe32 );
> +    if (dwUnicode & ENUM_ALL_FAMILIES) fe32.dwFlags &= ~ENUM_ALL_FAMILIES;
>      fe32.dwFlags &= ~ENUM_CALLED;

You can just unconditionally remove ENUM_ALL_FAMILIES mask simultaneously with
ENUM_CALLED.

In order to simplify the logic why not just introduce 1 additional BOOL param
to WineEngEnumFonts that would mean ENUM_ALL_FAMILIES? That way there is no
need to expose an internal structure and flags to freetype.c.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the wine-bugs mailing list