[Bug 8520] combobox dropdown area should be customisable

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=8520


Aric Stewart <aric at codeweavers.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #10 from Aric Stewart <aric at codeweavers.com>  2008-04-11 09:25:06 ---
This should be corrected by this patch:

diff --git a/dlls/user32/combo.c b/dlls/user32/combo.c
index 14eebe8..0e66b7d 100644
--- a/dlls/user32/combo.c
+++ b/dlls/user32/combo.c
@@ -1107,7 +1107,7 @@ static void CBDropDown( LPHEADCOMBO lphc )
       {
             if (nItems < 5)
                 nDroppedHeight = (nItems+1)*nIHeight;
-            else
+            else if (nDroppedHeight < 6*nIHeight)
                 nDroppedHeight = 6*nIHeight;
       }
    }

(In reply to comment #7)
> ea60a508b1810ea9f901f0cd4cf5f0bae4690525 is first bad commit
> commit ea60a508b1810ea9f901f0cd4cf5f0bae4690525
> Author: Aric Stewart <aric at codeweavers.com>
> Date:   Fri Feb 2 15:04:23 2007 -0600
> 
>     user32: We are calculating the height for the drop down based on
>     number of items however the if statement used nIHeight (just the
>     height of 1 item) and not nHeight (the height all the items).
> 


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.