[Bug 14861] Nokia Suite 7.0 installer crashes

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=14861


Damjan Jovanovic <damjan.jov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |damjan.jov at gmail.com




--- Comment #6 from Damjan Jovanovic <damjan.jov at gmail.com>  2008-08-17 06:27:40 ---
The obvious problem I see with this patch is that it doesn't handle the case of
overlapping src/dst rectangles on the same bitmap - an easy case to miss, I did
the same in one of my patches.

At the very least, memmove() needs to be used instead of memcpy(), and the rows
should be copied in such a way that previously copied rows are not overwritten.
The former doesn't help Nokia PC Suite, and the latter takes a lot of thought
to code.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.