[Bug 9775] Syberia 2, Max Payne 1 & 2 - Screenshots and thumbnails broken

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=9775





--- Comment #25 from Alexander Dorofeyev <alexd4 at inbox.lv>  2008-07-01 12:12:03 ---
(In reply to comment #24)
> Wine's implementation of D3D is based on what you can read in the MSDN. If the
> MSDN is wrong then we should comment that in wine's code.

I'm not sure, but I may guess that clarity may have been the concern. I think a
small note in IDirect3DDevice8Impl_CreateImageSurface (something like "creates
a surface in sysmem pool. max payne and other games rely on that") will
suffice. The rest is "documented" by test. For already implemented and tested
Wine code we probably don't want to care too much about what msdn says anyway
and give it lots of space (anything on msdn can be altered or removed any time
btw, whenever ms deems fit). Comments in d3d9 that are wrong can be simply
deleted, but maybe in different patch.

> I have an idea Alexander, why don't you hand in the (my) patch? I guess it's
> going to be applied in no time ;-)

It's more fair if your fix goes in under your name, and it's not like my
patches don't ever get delayed or rejected (sigh)...


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.