[Bug 13112] comctl32 trackbar setPos() should not call oncustomdraw if value hasn't changed

wine-bugs at winehq.org wine-bugs at winehq.org
Sat Jul 5 13:44:48 CDT 2008


http://bugs.winehq.org/show_bug.cgi?id=13112


Mikolaj Zalewski <mikolaj.zalewski at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikolaj.zalewski at gmail.com




--- Comment #2 from Mikolaj Zalewski <mikolaj.zalewski at gmail.com>  2008-07-05 13:44:47 ---
I see that a mail was sent to wine-patches but the patch wasn't applied. This
could be because... you didn't attach the patch to the mail :). Also you should
make the subject more descriptive for a changelog entry - e.g. 'comctl32:
trackbar: make sure a MN_CUSTOMDRAW is no sent after a TBM_SETPOS'. In the
message body you can add that it fixes the problem in bug #13112 so that people
see you are fixing a real problem and not nitpicking.

The patch itself seems correct. Of course, it would be great if you would also
include a test added to dlls/comctl32/tests/trackbar.c.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the wine-bugs mailing list