[Bug 12074] The conformance tests fail on Windows

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=12074


Austin English <austinenglish at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |austinenglish at gmail.com




--- Comment #5 from Austin English <austinenglish at gmail.com>  2008-06-11 16:46:38 ---
Many thanks to James for all those tests fixes. Looking at test.winehq.org is
now _MUCH_ easier on the eyes.

I've noticed a bit on wine-devel a bit of discussion on version checking, and
I'm debating filing a bug for it, but haven't yet. It seems that since so much
of windows behavior changes by version, that instead of doing:

--pseudo code--
ok(!result && (GetLastError() == ERROR_A|| GetLastError() == ERROR_B)

That we should be doing

if (win_version == WIN_98)
then ((GetLastError() == ERROR_A))
elseif (win_version == WIN_2K)
then ((GetLastError() == ERROR_B))

etc...

While not as clean of an implementation, neither is the reset of win32 API. It
would allow for a truer test of windows functions, as we'd be able to ensure
that we're conforming to the _right_ windows behavior rather than _some form_
of windows behavior.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.