[Bug 9775] Max Payne 1.05 - Screenshot fails

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=9775





--- Comment #20 from Alexander Dorofeyev <alexd4 at inbox.lv>  2008-06-19 17:15:41 ---
(In reply to comment #19)
> Created an attachment (id=14192)
 --> (http://bugs.winehq.org/attachment.cgi?id=14192) [details]
> test_image_surface_pool
> 
> Rewritten test according to advices from Alexander.
> 
> Currently the test goes into surface.c, but device.c should be more correct
> (since CreateImageSurface is a device method. I didn't put it into device.c
> because surface.c already does all d3d init stuff for me and just hands me the
> proper setup device.
> 
> The test itself should be correct now. It fails in wine and passes on windows
> xp. Vista still needs a test.

I think surface.c is ok for this test. Sure it's created by a device method,
but any surface or texture can only be created by methods of device and all
tests in surface.c use one or another device method. Important that it tests
properties of a surface.

If you remove // comments and change CreateImageSurface to do the right thing,
it should be ok to submit to wine-patches IMO (patches are generated by
git-diff or git-format-patch, see 
http://www.winehq.org/site/sending_patches). Test passes XP + fixes a game
should be enough.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.