[Bug 9787] Warcraft3 Battle.net Doesn't work (Needs AcceptEx)

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=9787


Scott Lindeneau <slindeneau at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slindeneau at gmail.com

Raul <rcioldin at yahoo.com.br> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rcioldin at yahoo.com.br




--- Comment #206 from Scott Lindeneau <slindeneau at gmail.com>  2008-06-21 09:07:50 ---
I have been reviewing the patch that Andrey Turkin submitted 2008-01-08 and
would like to throw my 2 cents in. I haven't programmed in wine before, but I
wouldn't mind starting. Please tell me how/if/why I am wrong.

1) AcceptEx can return synchronously, but it doesn't matter if it does or not.
   * This means that for simplicity it shouldn't.

2) The AcceptEx call has all of the information it needs when its called.
   * All of the variables passed to AcceptEx must be initialized before it is
called.
   * The AcceptEx function itself should only be a wrapper for a wine server
call to start an async accept, and then it should return.

3) Essentially AcceptEx is an easy way to ask the Operating System to start a
thread to listen on a socket, and to get rid of the thread automatically.
   * We ask the wine server for an async accept (which should just be spawn a
thread, listen, and return after connect)

4) AcceptEx only adds the ability to read data on the socket before the
socket's error status changes from IO_PENDING to whatever.
   * Why not add this functionality into the wine server's async accept?


--- Comment #207 from Raul <rcioldin at yahoo.com.br>  2008-06-24 13:32:33 ---
acceptex unnofficial patch in deb package please!


--- Comment #208 from Austin English <austinenglish at gmail.com>  2008-06-24 16:11:23 ---
(In reply to comment #207)
> acceptex unnofficial patch in deb package please!
> 

Ask the maintainer to do that. Hacks are not accepted in WineHQ's codebase.

You could compile it yourself...


--- Comment #209 from Raul <rcioldin at yahoo.com.br>  2008-06-24 17:55:56 ---
after a long time downloading and compiling....

the "Disable completion port creation" patch didn't work...

I just have to get in my git dir and do
"patch -Np1 < mypatch.diff && tools/make_requests"???


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.