[Bug 13000] Audiosurf crashes on startup

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=13000


Olivier Samyn <olivier-ml1 at oleastre.be> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olivier-ml1 at oleastre.be




--- Comment #4 from Olivier Samyn <olivier-ml1 at oleastre.be>  2008-05-07 03:21:26 ---
Isn't this related to the problem I found I bug #12979 ? 

In from dlls/quartz/filesource.c, function AsyncReader_GetPin, sometimes,
This->pOutputPin is null => crash when you try to add a reference on it.

Just adding a test and returning S_FALSE if null resolved my problem.

diff --git a/dlls/quartz/filesource.c b/dlls/quartz/filesource.c
index f410b56..a4e708f 100644
--- a/dlls/quartz/filesource.c
+++ b/dlls/quartz/filesource.c
@@ -533,6 +533,10 @@ static HRESULT AsyncReader_GetPin(IBaseFilter *iface,
ULONG
         return S_FALSE;

     *pin = (IPin *)This->pOutputPin;
+    
+    if(!(*pin))
+        return S_FALSE;
+    
     IPin_AddRef(*pin);
     return S_OK;
 }


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.