[Bug 9615] RPG Maker, Fritz9, Amazon Music Downloader: crash when clicking menu bar

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=9615





--- Comment #33 from Dusan Saiko <dusan.saiko at gmail.com>  2008-10-12 20:49:05 ---
-- so there are two ways, how to easily fix this issue:
- fix null pointer exception by not sending 0 as window handle 
- and
- a) call EndMenu from WM_CANCELMODE handler of defwnd.c (remove the if
condition)
- or
- b) use undocumented message 0xb09 to cancel the menu loop

I actually think, either of them can be used.

For a) - if CANCELMODE message is sent, then menu should be closed,  EndMenu
just sets fEndMenu variable and then calls PostMessageW( top_popup,
WM_CANCELMODE, 0, 0); may be I would add some condition to prevent any possible
WM_CANCELMODE loop

For b) - the "fix" does not do anything else just ends the menu loop when
message 0xb09 is sent. Even this is not documented, it fixes the issue in
correct way, loop should not be running after this message.

So, in summary, I am done here. 
It is possible to get rid of this quite serious bug in few lines change (I
can't do it, somebody else would have to), 
but well, may be it is better to leave it open for several next years, and keep
given set of applications crashing .... 


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.