[Bug 13137] IE6 crashes due to unimplemented function wininet.dll.GetDiskInfoA

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=13137


Detlef Riekenberg <wine.dev at web.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wine.dev at web.de
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|ABANDONED                   |




--- Comment #13 from Detlef Riekenberg <wine.dev at web.de>  2008-09-29 00:04:53 ---
This is still an issue on Wine-1.1.5.

1. Download ie5.5 from browsers.evolt.org
   ( I used
http://www.mirrorservice.org/sites/browsers.evolt.org/browsers/ie/32bit/standalone/ie55sp2_nt.zip)

2. unzip

3. Apply this Patch for "URLRegSubQueryA" to avoid a crash:
   http://www.winehq.org/pipermail/wine-patches/2008-September/061943.html

4. wine control INETCPL.CPL

5. Press "Settings" or "Delete Files"

Hi John. The Patch works, but I have some suggestions:
- When the function succeeded, then do not test GetLastError()
- You test with NULL for free_bytes  and NULL for total_bytes and
  your code return FALSE, but you did not call SetLastError()
- Your test set the results to 0, but you should set it to an unusal value
  (we use 0xdeadbeef in the tests, but this is a valid result, so use -1)
  and check, if the result is cleared on Windows or not
  (Do that also in your implementation, when needed)
- You can test more things, to learn, when the Functon should succeed and
  which error-code should be returned on failure
  (a drive without a pathname, but with a backslash / drive without backslash /
  a different case for he drive letter / a drive, that does not exist /
  an Empty string)
- you test with NULL for the Path. Make sure, that older Windows versions
  do not crash, when running the test:
- Run the test on windows, and when you send the Patch, write in the message,
  on which Windows-Version the test was tested
  (Asking on wine-devel for help for testing on various versions is a good
Idea)

(I'm offline for a while, so when you need more help,
please ask on wine-devel or on #winehackers)


Thanks for helping Wine

-- 
By by ... Detlef


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.