[Bug 18045] New: Dangerous usage of strncat

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=18045

           Summary: Dangerous usage of strncat
           Product: Wine
           Version: 1.1.19
          Platform: Other
               URL: http://cppcheck.wiki.sourceforge.net/
        OS/Version: other
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: -unknown
        AssignedTo: wine-bugs at winehq.org
        ReportedBy: begert at gmail.com
                CC: begert at gmail.com


Running cppcheck 1.31 against wine 1.1.19 yeilds:


[./dlls/mciavi32/info.c:257]: (all) Dangerous usage of strncat, possible buffer
overrun

Currently the code looks like:

strncat(buffer, " seek_exactly", sizeof(buffer));


Looking at the strncat man page, perhaps better usage would be:

strncat(buffer, " seek_exactly", sizeof(buffer) - strlen(buffer) - 1);


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.