[Bug 18045] Dangerous usage of strncat

wine-bugs at winehq.org wine-bugs at winehq.org
Tue Apr 14 11:42:49 CDT 2009


http://bugs.winehq.org/show_bug.cgi?id=18045


Vincent Povirk <madewokherd at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |madewokherd at gmail.com




--- Comment #2 from Vincent Povirk <madewokherd at gmail.com>  2009-04-14 11:42:49 ---
This is in the MCIAVI_mciSet function.

The string buffer is only used to output debugging information, and all of the
source buffers are constant strings. The buffer is long enough that the
function won't overrun it. So this isn't really going to cause any problems.

That said, because it's all debugging information from constant strings,
there's no need to build a string buffer in this function at all.

I'll send a patch.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the wine-bugs mailing list