[Bug 18997] Warcraft 3 1.23 crashes after remaining one minute in a Battle.net chat room.

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=18997





--- Comment #8 from Juan Lang <juan_lang at yahoo.com>  2009-08-07 17:52:05 ---
(In reply to comment #6)
> Do you had another reason for your patch then fixing this bug?

Yes, there was another application that called DeleteSecurityContext twice on
the same handle, detailed in bug 19564.

> As you might know I tried to submit a similar patch, but got told that
> returning NULL is a bad idea:
> http://www.winehq.org/pipermail/wine-devel/2009-March/074267.html
> I intended then to write a updated patch:
> http://www.winehq.org/pipermail/wine-devel/2009-March/074277.html
> but another response coming a few minutes later convinced me to do more
> research:
> http://www.winehq.org/pipermail/wine-devel/2009-March/074278.html

Regression tests would be ideal.  I took the fact that multiple applications
were calling DeleteSecurityContext twice on the same handle as an indicator
that it is legal to do so in Windows.  I suppose that's the key difference from
when you wrote your patch:  more than one application was failing in the same
way.  That, plus my Julliard rank is probably a little higher ;-)

> Maybe your second change does make the difference, but I can't test right now
> if it does. It may take weeks until I can access a PC again which can run
> Warcraft 3.

Yes, please do, and reopen this if it isn't fixed by then.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.