[Bug 8421] Disk Explorer Pro 3.60 crashes when browsing or searching

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=8421


Nikolay Sivov <bunglehead at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|wine-bugs at winehq.org        |bunglehead at gmail.com




--- Comment #15 from Nikolay Sivov <bunglehead at gmail.com>  2009-08-10 16:07:31 ---
I think I found why does it crash here. Application data/buffer/map isn't ready
at a point when we're requesting dispinfo text for drawing operation. We really
shouldn't draw yet at this point and shouldn't request anything from parent.
Bug is in WM_SETREDRAW handling.

Minimal patch looks like that:

---
diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c
index a65d832..ebcba6b 100644
--- a/dlls/comctl32/listview.c
+++ b/dlls/comctl32/listview.c
@@ -4334,6 +4334,8 @@ static void LISTVIEW_RefreshReport(LISTVIEW_INFO
*infoPtr, ITERATOR *i, HDC hdc,

     TRACE("()\n");

+    if (!is_redrawing(infoPtr)) return;
+
     /* figure out what to draw */
     rgntype = GetClipBox(hdc, &rcClip);
     if (rgntype == NULLREGION) return;
---

It allows browsing of precreated database (first time after creation it works
without patching).

Let's assign it to me, will start with testing on this WM_SETREDRAW.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.