[Bug 18993] Shadows and selection circles z-fight in World of Warcraft

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=18993





--- Comment #7 from Henri Verbeet <hverbeet at gmail.com>  2009-12-30 03:20:01 ---
(In reply to comment #6)
> I've been running Wow and wine with this patch and it fixes the problem and I
> have not noticed any side effects.  Out of curiosity, why do you think it looks
> incorrect, Henri? If I am wrong here I would like to know. I assume that you
> have seen the z-fighting that Lisa reported.  Let me know your thoughts.

It makes sense to scale the WINED3DRS_DEPTHBIAS value if the value is specified
in normalized depth coordinates for D3D. However, WINED3DRS_SLOPESCALEDEPTHBIAS
is a scaling factor for the depth slope, so I don't think it makes sense to
scale that one.

My patch is almost the same as yours, but doesn't scale
WINED3DRS_SLOPESCALEDEPTHBIAS. It also uses 1e6f instead of 9.6e7f for the
WINED3DRS_DEPTHBIAS scaling factor, but I think that with the exact scaling
factor being device and driver dependant that shouldn't make much of a
difference. 9.6e7f corresponds with 1/2^20, I guess, but it's not an exact
representation anyway.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.