[Bug 14334] WordPerfect Office 2002: Unable to Install

wine-bugs at winehq.org wine-bugs at winehq.org
Mon Feb 9 16:53:14 CST 2009


http://bugs.winehq.org/show_bug.cgi?id=14334





--- Comment #21 from Forester <pbronline-wine at yahoo.co.uk>  2009-02-09 16:53:13 ---
(In reply to comment #20)
> Is this commit related,
> advapi32: Support the computer name as an account name in LookupAccountNameW
> http://www.winehq.org/pipermail/wine-cvs/2009-February/052769.html
> ?
> 
> What's the full set of proposed patches needed (links to wine-patches best)?
> 

No, I don't think so.  Thanks for drawing it to my attention.  I note Juan has
used subroutines as a way of refactoring.  Noted for next time.  If there is a
next time.

Here's a reference (I hope) to the patches I submitted ...

http://www.nabble.com/-PATCH-01-12--(resend)-LookupAccountNameW()---add-got-clause-to-test-to20084179.html#a20084179

That's the first of a series of 12.  I don't know how to navigate nabble, so I
searched for:

Paul Bryan Roberts resend

and that pulled up all 12.  If memory serves, only the first nine were accepted
and so only my first two objectives were met.  The routine was in serious need
of refactoring.  The corrections to existing conformance tests were accepted
but the refactoring was not.  I got no feedback as to why, I'd spent way to
much time on the problem and the patches weren't the break-through I'd been
hoping for so I let it drop.

Since I've concluded that my later patches fell into the 'obviously not
obviously correct' category, obviously and that further progress on this bug
would be dependent on coming up with new conformance tests that fail.

Looking back, it seems I did add a couple more conformance tests that Wine
doesn't pass without my patches.  Ho, hum.

Here's the stub

http://www.nabble.com/advapi%3A-add-stub-for-GetNamedSecurityInfoExA()-to20337526.html#a20337526

Other patches, notably those that made GetFileSecurity cope with directories,
were all accepted.

Does this help ?


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the wine-bugs mailing list