[Bug 13469] cmd can't handle long input (buffer overflow)

wine-bugs at winehq.org wine-bugs at winehq.org
Sat Feb 21 05:23:59 CST 2009


http://bugs.winehq.org/show_bug.cgi?id=13469





--- Comment #15 from Nikolay Sivov <bunglehead at gmail.com>  2009-02-21 05:23:59 ---
(In reply to comment #14)
> (From update of attachment 19236 [details])
> This patch allows command-lines as long as 8192 character when using the
> interactive input(not /c or batch files), any limitations imposed by this patch
> come from Windows' cmd.exe
> 
> I wrote a small testsuite for cmd and I'll work on expanding and automating it
> and adding it to wine.
> 
> Detailed changes:
> Fixed a number of buffer overflows (based on limits of Windows cmd.exe):
>     - Each of param1 and param2 can be almost as long as MAXSTRING(actually a
> few characters shorter) so their length was changed.
>     - Fixed an overflow with long program names(aka stemofsearch), it can't be
> equal to or longer than MAX_PATH.
>     - Fixed an overflow in WCMD_DumpCommands with long commands by removing the
> fixed-length buffer and using WINE_TRACE instead of buffer+sprintf.
> 

Post it to wine-patches. Change your 'const WCHAR c[]' message to use resource
located string, if it supposed to be localized.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the wine-bugs mailing list