[Bug 14749] riched20: Fix vertical scrolling

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=14749


Dylan Smith <dylan.ah.smith at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|wine-bugs at winehq.org        |dylan.ah.smith at gmail.com
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1




--- Comment #10 from Dylan Smith <dylan.ah.smith at gmail.com>  2009-01-11 01:33:04 ---
Created an attachment (id=18632)
 --> (http://bugs.winehq.org/attachment.cgi?id=18632)
Fix a bug in calculating whether the vertical scrollbar was visible.

The calculation to see if the scrollbar was visible was subtracting from an
unsigned integer that is initially 0, so this would cause the value to wrap
around.  This calculation should be the same as the calculating to find out the
scrollbar will be visible, so I changed it accordingly.

The bug this patch fixes can be seen by opening winhlp32 with a small help file
specified on the command line.  The vertical scrollbar would initially be
visible, even though there is less than a page of text.

I think the other bugs with vertical scrolling have already been fixed. I have
already made some changes to scrolling recently that have been committed, and I
still need to submit (including implementing the horizontal scrollbar).

Let me know if this bug seems fixed, or provide a clear series of steps to
reproduce remaining bugs.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.