[Bug 10394] No$gba Open file dialog non-resizable (OFN_ENABLESIZING not implemented)

wine-bugs at winehq.org wine-bugs at winehq.org
Sun Jan 25 15:27:00 CST 2009


http://bugs.winehq.org/show_bug.cgi?id=10394





--- Comment #7 from Austin English <austinenglish at gmail.com>  2009-01-25 15:26:59 ---
(In reply to comment #6)
> Created an attachment (id=18982)
 --> (http://bugs.winehq.org/attachment.cgi?id=18982) [details]
> An initial patch that makes the Open file dialog resizable
> 
> There are several modifications that need to be done, I know, I just wanted to
> submit an early working patch to see how am I doing as this is my first patch
> to WINE, so any comments are appreciated.
> 
> This enables resizing always, whether OFN_ENABLESIZING is specified or not,
> this will be fixed, also it affects only the open file dialog.
> 
> A good sample for testing is wxwidget's dialogs sample[1], run it then press
> Ctrl-O.
> 
> [1] ftp://biolpc22.york.ac.uk/pub/binary/wxWidgets-WidgetsDemo-Windows.zip
> 

You'd be better off sending it to wine-devel and ask for comments. Patches
aren't really looked at here.

Before doing so, though, two comments:
A) No C++ comments (//), use /* comment */ instead.
B) A testcase would help substantially.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the wine-bugs mailing list