[Bug 20335] New: Uninitialised memory reference in X11DRV_DIB_SetImageBits()

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=20335

           Summary: Uninitialised memory reference in
                    X11DRV_DIB_SetImageBits()
           Product: Wine
           Version: 1.1.31
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Keywords: download
          Severity: normal
          Priority: P2
         Component: winex11.drv
        AssignedTo: wine-bugs at winehq.org
        ReportedBy: dank at kegel.com


I think this is one of the first valgrind warnings
I ever ran into in wine, and it's still here.
Nowadays Wine gives better warnings, so it's a little
easier to see where these are coming from.

Running chromium's base_unittests.exe (and probably
lots of other apps) in valgrind yields this warning:

Conditional jump or move depends on uninitialised value(s)
   at XcursorImageHash (xlib.c:294)
   by XcursorNoticePutBitmap (xlib.c:365)
   by _XNoticePutBitmap (CrGlCur.c:202)
   by XPutImage (PutImage.c:1042)
   by X11DRV_DIB_SetImageBits (dib.c:3670)
   by X11DRV_SetDIBits (dib.c:4040)
   by SetDIBits (dib.c:361)
   ...
 Uninitialised value was created by a client request
   at RtlAllocateHeap (heap.c:187)
   by X11DRV_DIB_SetImageBits (dib.c:3543)
   by X11DRV_SetDIBits (dib.c:4040)
   by SetDIBits (dib.c:361)
   ...

Presumably adding HEAP_ZERO_MEMORY to the allocation
at dib.c:3543 would do the job, but maybe there's a
smarter way.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.