[Bug 20334] SysReAllocStringLen should return null terminated strings

wine-bugs at winehq.org wine-bugs at winehq.org
Tue Oct 13 03:55:09 CDT 2009


http://bugs.winehq.org/show_bug.cgi?id=20334





--- Comment #9 from A. Kochetkov <al.kochet at gmail.com>  2009-10-13 03:55:09 ---
(In reply to comment #6)
> A small comment here. Could you reduce the buffer size? Or allocating 8K really
> means something?

It doen't means something for wine, but under XP with 95, 98, Me compatability
mode, new allocated string is outside of previous if CHUNK_SIZE is less than
16384. Range test fails, so I cannot assert is null terminator always present.
But, with 16394, range test pass, new string allocated on the old string with
trash, and new string is null terminated.

(In reply to comment #7)
> One further small comment:  any tests that currently fail on wine need to be
> preceded with todo_wine.

I provide bug fix and test. Test with bug fix doesn't fail. Should I add
todo_wine?

Please review another version of patch.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the wine-bugs mailing list