[Bug 20485] New: Uninitialised memory reference in FTP_DoPassive

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=20485

           Summary: Uninitialised memory reference in FTP_DoPassive
           Product: Wine
           Version: 1.1.31
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: wininet
        AssignedTo: wine-bugs at winehq.org
        ReportedBy: dank at kegel.com


(Found via
http://kegel.com/wine/valgrind/logs/2009-10-26-08.26/diff-mshtml_htmllocation.txt
)

http://kegel.com/wine/valgrind/logs/2009-10-26-08.26/vg-mshtml_htmllocation.txt
shows

 Conditional jump or move depends on uninitialised value(s)
    at  FTP_DoPassive (ftp.c:3028)
  Uninitialised value was created by a client request
    at  mark_block_uninitialized (heap.c:187)
    by  RtlAllocateHeap (heap.c:1429)
    by  INTERNET_AllocThreadError (internet.c:3050)
    by  INTERNET_GetResponseBuffer (internet.c:3174)
    by  FTP_DoPassive (ftp.c:3019)

I suspect it's the unconditional skip of four bytes...
maybe that skips over the terminating null sometimes.

   3027    p = lpszResponseBuffer+4; /* skip status code */
   3028    while (*p != '\0' && (*p < '0' || *p > '9')) p++;

The code is not new, but the error is, so maybe this only happens
if there's a network error.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.