[Bug 22366] Call of Duty 4 is black in-game

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=22366





--- Comment #12 from Henri Verbeet <hverbeet at gmail.com>  2010-04-17 17:14:54 ---
(In reply to comment #11)
> There are a lot of different codepaths in wined3d. You do test certain apps and
> run the wine d3d tests (and also extend them) but you don't always cover all
> situations.
> 
> The d3d test coverage should be improved to prevent more regressions. Writing
> tests can be boring though. When I rewrite a piece I try to add some tests. In
> this specific case I wrote one for the ColorFill behavior and didn't look too
> much at the Clear behavior (I expected the current test to be enough there).
> Especially for trickier areas, I'll try to write more tests when I touch such
> an area.

More tests would be good of course, but you can hardly blame this one on the
test coverage. I have the strong impression that this patch was created by
simply copying around some code from color_fill_fbo() (compare the original
http://www.winehq.org/pipermail/wine-patches/2010-April/087103.html with
http://source.winehq.org/git/wine.git/?a=blob;f=dlls/wined3d/device.c;h=91e595c0afbf6bde0241817cc1bc314b9f4e249f;hb=10f58c14bcdeba9f7ea82701b9d9ab8f2bb3414b#l5444),
without much understanding of what the involved code does.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.