[Bug 17503] Diablo 2 refuses to detect D3D device

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=17503


Wylda <wylda at volny.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wylda at volny.cz




--- Comment #13 from Wylda <wylda at volny.cz>  2010-01-02 07:25:54 ---

To begin with i thought this is Stefan Dösinger's breakage, than it looked like
Roderick will be also involved, but finally i think Roderick will be all alone
in this...


Try to do my best to clarify this bug report. Regression test between 1.1.2 and
1.1.3 showed

wine-1.1.2-425-g3d49e8c  --GOOD (3d49e8cd5e3872c06c5b86f8d2bb0cc41d5ddfa9)
wine-1.1.2-426-gc1bbab7  --BAD  (c1bbab7c54618935d74b7d2b70421253018f5594)

c1bbab7c54618935d74b7d2b70421253018f5594 is first bad commit
commit c1bbab7c54618935d74b7d2b70421253018f5594
Author: Stefan Dösinger <stefan at codeweavers.com>
Date:   Thu Aug 7 14:09:19 2008 -0500

    ddraw: Send the ddraw output to the clipper window, if any.

:040000 040000 4a60a1c2a59103c9cad3185898bbc59553289b35
f18be73670fd3c5b13d36a1b959fde64c8808fe7 M      dlls



But to end up this bug report here would be mistake, because reverting
c1bbab7c54618935d74b7d2b70421253018f5594 on top of 1.1.3 does not help.


So further testing showed another regression

wine-1.1.2-632-gb917bda with reverted SDO's patch  --GOOD
wine-1.1.2-633-gfd0e601  --BAD (fd0e60180a1979e3dd8730bd4922556a73353ea6)

fd0e60180a1979e3dd8730bd4922556a73353ea6 is first bad commit
commit fd0e60180a1979e3dd8730bd4922556a73353ea6
Author: Roderick Colenbrander <thunderbird2k at gmx.net>
Date:   Thu Aug 21 20:51:18 2008 +0000

    wined3d: Fix window rewrite regression.

:040000 040000 4a91a1dc05bd7ac7c504f692816aa7feb0136907
d68dc0add2d65ff87f465ebb4852e3aba67ac5ee M      dlls



Reverting these TWO patches on top of 1.1.3 make Diablo's D2VidTst.exe happy
again. But to end up this bug report here would be second mistake in a row.

So playing with 1.1.34 showed, that it's enough to revert just ONE patch -
Roderick's patch.

Can't test further because in 1.1.35 there were some code movement to
swapchain.c and that is too much for "hello word!" programmer like me ;) You
can easily test it with Diablo 2 Demo.


--private keyword: bisected

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.