[Bug 22918] Ship Simulator 2008 demo crashes on startup (needs D3DXCreateSphere, D3DXCreateCylinder, and D3DXCreateTeapot)

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=22918





--- Comment #47 from Misha Koshelev <misha680 at gmail.com>  2010-07-27 15:54:06 ---
(In reply to comment #45)
> (In reply to comment #44)
> > Created an attachment (id=29848)
 --> (http://bugs.winehq.org/attachment.cgi?id=29848) [details] [details]
> > Temporary patches for D3DXCreateMeshFVF/ID3DXMesh for wine-devel
> > 
> > My apologies... either wine-devel scrubs my attachments and does not get my
> > posts through or the web interface does not seem to pick up the emails in
> > time... in any case I wanted to make sure to get this out.
> 
> If you mean the wine-patches archives with web interface, that one usually only
> gets refreshed every two hours or something.
> Anyway, from my personal experience, quick-but-not-quite-correct patches with
> the promise of "doing it properly lateron" tend to get rejected with the reason
> "no, do it properly from the beginning"... i.e. you should prolly implement
> D3DXCreateMesh first, it's not that much work anyway.

Ok, here is my argument why we _should_ use FVFs internally:
1) D3DXCreateMesh _only_ allows declarations that map to FVFs
http://msdn.microsoft.com/en-us/library/bb172780%28v=VS.85%29.aspx

pDeclaration [in]
    LPD3DVERTEXELEMENT9

    Array of D3DVERTEXELEMENT9 elements, describing the vertex format for the
returned mesh. This parameter must map directly to a flexible vertex format
(FVF).

2) If we implement D3DXCreateMesh first we still have to implement
D3DXFVFFromDeclarator for index buffer creation

IDirect3DDevice9::CreateIndexBuffer
http://msdn.microsoft.com/en-us/library/bb174357%28VS.85%29.aspx

3) The goal of wine, per Alexandre's private email to myself:

---
Our goal is not to implement the Win32 API just for the sake of it, it's
to run actual Windows applications. So APIs that are not used in real
life don't need to be implemented.
---
(FYI this had to do with a teapot discussion and so is clearly taken out of the
context. However, I believe the point I got from this is that our goal is to
make things work on Wine. FVFs would work much better and make implementation
quite a bit easier to make Ship Simulator 2008 demo work (better) under Wine.

Thanks
Misha

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.