[Bug 21846] TREPCAD 4.4.1 Demo: install aborts

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=21846


Louis Lenders <xerox_xerox2000 at yahoo.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Installer
             Status|UNCONFIRMED                 |NEW
                 CC|                            |xerox_xerox2000 at yahoo.co.uk
     Ever Confirmed|0                           |1




--- Comment #1 from Louis Lenders <xerox_xerox2000 at yahoo.co.uk>  2010-03-02 15:55:14 ---
confirming. Below is a hack that let's the installer complete.

The problem seems to be a program called vsda.exe (installed in TREPCAD
directory) that returns an exitcode 1 when run from the msi installer.So
GetExitCodeProcess( process, &rc ) returns for rc 1.

I don;t know what the bug really is; maybe msi on windows ignores this, and
returns succes anyway, or the program vsda.exe returns successfull exitcode 0
on windows. As i haven't got a clue what this program is or does (when run
directly from the console it just returns to the console quietly), this remains
a mystery for now










diff --git a/dlls/msi/custom.c b/dlls/msi/custom.c
index 2b2a3e1..8b6dcf3 100644
--- a/dlls/msi/custom.c
+++ b/dlls/msi/custom.c
@@ -436,8 +436,9 @@ static UINT custom_get_process_return( HANDLE process )
     DWORD rc = 0;

     GetExitCodeProcess( process, &rc );

     if (rc != 0)
-        return ERROR_FUNCTION_FAILED;
+        return 0;
     return ERROR_SUCCESS;
 }

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.