[Bug 22034] New: EXIT_ON_ERROR should use ERR instead of WARN in winealsa.drv

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=22034

           Summary: EXIT_ON_ERROR should use ERR instead of WARN in
                    winealsa.drv
           Product: Wine
           Version: 1.1.40
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: blocker
          Priority: P2
         Component: -unknown
        AssignedTo: wine-bugs at winehq.org
        ReportedBy: superquad.vortex2 at gmail.com


In winealsa.drv , WARN() should not be used in EXIT_ON_ERROR() since those
functions in waveout.c and wavein.c are all fatal errors

(e.g. snd_pcm_hw_params_set_period_time() may return error on when using "hw"
device for some alsa driver by modifying registry "ALSA Driver" "UseDirectHW"
to "Y" for those hardware mixing sound cards)

wine is unable to report those error message for those alsa drivers 


 #define EXIT_ON_ERROR(f,e,txt) do \
 { \
     int err; \
     if ( (err = (f) ) < 0) \
     { \
      WARN(txt ": %s\n", snd_strerror(err)); \
+      ERR(txt ": %s\n", snd_strerror(err)); \
     retcode=e; \
     goto errexit; \
     } \
 } while(0)

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.