[Bug 22758] New: MS Office 2007: riched20 assertion failure in CDKey registration screen

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=22758

           Summary: MS Office 2007: riched20 assertion failure in CDKey
                    registration screen
           Product: Wine
           Version: 1.1.44
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: richedit
        AssignedTo: wine-bugs at winehq.org
        ReportedBy: aeikum at codeweavers.com
                CC: dylan.ah.smith at gmail.com


Typing an invalid character (e.g. A or 1) into the MSO2007 CDKey registration
text box causes an assertion failure in dlls/riched20/undo.c:387.

undo.c:387: ME_Undo: Assertion `editor->pUndoStack->type ==
diUndoEndTransaction || editor->pUndoStack->type ==
diUndoPotentialEndTransaction' failed.


I bisected this and found 049cf5aca0a2daafe0ce078757ad60f1a1cadc9e as the bad
commit:

commit 049cf5aca0a2daafe0ce078757ad60f1a1cadc9e
Author: Dylan Smith <dylan.ah.smith at gmail.com>
Date:   Fri May 14 20:11:28 2010 -0400

    richedit: Avoid notifying parent window in improper state.

    ME_CommitUndo and ME_CommitCoalescingUndo call ME_SendSelChange, which
    may notify the parent window that the selection has changed, therefore
    should generally be called after wrapping the text. Otherwise, the parent
    window may send a message to the editor and cause an assertion failure.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.