[Bug 19811] Visual C 2005 redistributable installers create many empty directories in WinSXS

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=19811





--- Comment #8 from Anastasius Focht <focht at gmx.net>  2010-05-30 10:58:11 ---
Hello,

--- quote ---
This should be fixed, we don't call msi_create_component_directories
in the CreateFolder action anymore. Please retest.
--- quote ---

Nope, even if "CreateFolder" behaviour is fixed now, "InstallFiles" action will
still do, see second part of my comment.

--- quote ---
...
"InstallFiles" action (which also calls msi_create_component_directories()
helper) should only create target folder structure for files that are really
copied/uncompressed.
--- quote ---

--- snip dlls/msi/files.c ---
/*
 * ACTION_InstallFiles()
 * 
 * For efficiency, this is done in two passes:
 * 1) Correct all the TargetPaths and determine what files are to be installed.
 * 2) Extract Cabinets and copy files.
 */
UINT ACTION_InstallFiles(MSIPACKAGE *package)
{
    MSIMEDIAINFO *mi;
    UINT rc = ERROR_SUCCESS;
    MSIFILE *file;

    /* increment progress bar each time action data is sent */
    ui_progress(package,1,1,0,0);

    schedule_install_files(package);

    /*
     * Despite MSDN specifying that the CreateFolders action
     * should be called before InstallFiles, some installers don't
     * do that, and they seem to work correctly.  We need to create
     * directories here to make sure that the files can be copied.
     */
    msi_create_component_directories( package );

    mi = msi_alloc_zero( sizeof(MSIMEDIAINFO) );

    LIST_FOR_EACH_ENTRY( file, &package->files, MSIFILE, entry ) 
...
--- snip dlls/msi/files.c ---

So unfortunately this isn't fixed.

Regards

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.