[Bug 14717] resampled sound is horrible

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=14717

--- Comment #23 from Alexander E. Patrakov <patrakov at gmail.com> 2010-11-26 11:38:01 CST ---
As for the code itself:

You are using a reference-counted buffer for the FIR. This can work only if you
guarantee that all the callers for FIR creation and destruction are in the same
thread. Otherwise, you can attempt to generate two FIRs concurrently. If thread
safety is indeed an issue, I'd suggest just dumping the coefficients into a
static array in a header file.

As for my earlier remark about the cutoff frequency in your code, I missed the
"cutoff = stopstart * resamp_ratio - (widthfac0 / FIR.width)" that explains it
all. Still, your FIR is shorter even than the "fastest" option in
libsamplerate. Libsamplerate seems to use a simple Gaussian window, maybe
that's the reason that you don't need such a long FIR.

About my earlier remark about buffer overflows: I found no such things in your
code, but it looks like the guard value that you allocated "just in case" at
the end of the FIR is sometimes accessed. I may be wrong, though. I know I
shouldn't review code at night :)

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.