[Bug 14717] resampled sound is horrible

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=14717

--- Comment #225 from Alexander E. Patrakov <patrakov at gmail.com> 2011-11-10 06:45:25 CST ---
Dear all,

please note that my patch is not supposed to magically fix all sound related
bugs ;) , its only purpose is to improve sound quality when some of the
application sounds use a sample rate different from the one you set in winecfg.
However, this bugzilla entry seems to be hijacked by the things unrelated to
sound quality that the attached patches also happen to fix.

I think most of the improvements that are not related to quality come from
always resampling sound in the mixer thread, which was not the default in the
old wine. I had to remove the other (i.e. the default) possibility, because it
cannot be implemented correctly when a resampler other than zero-order-hold is
used and the application is allowed to rewind its buffer.

The old wine resampled in the mixer thread if you set MaxShadowSize to -1 in
the registry. Personally, I am not interested in any breakage or improvements
that result merely from moving the resampling from the application thread to
the mixer thread. You are, of course, welcome to post such reports here,
because someone else may be interested, but please clearly indicate in every
report whether setting MaxShadowSize to -1 in the unpatched Wine leads to the
same improvement or breakage as you observe with my patch.

If most of the improvements actually come from moving the old bad resampler to
the mixer thread, then I suggest that Wine developers merge the first patch in
my series, and then we can discuss the rest of the patches separately, so that
the two types of issues are not mixed together.

Thanks!

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.