[Bug 29041] Star wars : The Old Republic launcher crashes due to custom cursors

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=29041

--- Comment #23 from Bruno Jesus <00cpxxx at gmail.com> 2011-11-16 10:04:35 CST ---
Erik, I probably understand the API as much as you do =)
You pointed out that in line 2163 there could be a problem but function
create_alpha_bitmap calls a function (GetObjectW) that calls another function
(GDI_GetObjPtr) that protects itself against the null pointer.

It seems that the problem is related to the 1x0 (width x height) cursor created
that is possibly invalid to the X server as per Ahmed log from comment 11:

0009:trace:cursor:GetIconInfoExW 0x52006c => 1x0
...
X Error of failed request:  BadPixmap (invalid Pixmap parameter)

I'm away of linux now so I can't create a new patch but what about changing
line 2146 (inside dlls/user32/cursoricon.c:CreateIconIndirect) from:

else height /= 2;

to:

else
{
   height /=2;
   if(!height) height=1;
}

This will make sure that in this case the icon will have at least 1px of
height. Can anyone manually apply and retest posting a new +cursor log?

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.