[Bug 27168] Eve Online: https pages won't load in In-Game Browser

wine-bugs at winehq.org wine-bugs at winehq.org
Sat Oct 15 19:57:25 CDT 2011


http://bugs.winehq.org/show_bug.cgi?id=27168

--- Comment #42 from Juan Lang <juan_lang at yahoo.com> 2011-10-15 19:57:25 CDT ---
(In reply to comment #41)
> I'd be happy to get any callback about the code actually.

My comments aren't going to be that nice to hear, unfortunately.  I'm happy
that you're trying to fix this, but I have to say your patch is difficult to
understand.  (Admittedly, so is the code, but that's a different problem.) 
That, combined with its length, and a lack of tests, means that I think the
odds of it getting accepted are basically nil.

Furthermore, assuming it's correct for certificates, it's still not entirely
correct:  the complicated reference logic applies to CRLs and CTLs too, so
you'd have to adjust those too.

So how to get there:
1. I can't emphasize enough the importance of test cases that demonstrate
what's wrong.
2. See if you can split your patch in some way.  Often, when the patch is
large, that means there are several problem you're addressing at once.  In that
case, one fix per patch is a good way to split the patch.

I hope that helps.  If you'd like to chat more about it sometime, try emailing
me at juan dot lang at gmail dot com or at wine-devel.

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.



More information about the wine-bugs mailing list